Emit warning when running on the controller with a Python older than 3.8 #72467

sivel · 2020-11-03T21:42:14Z

SUMMARY

Emit warning when running on the controller with a Python older than 3.8

Ansible 2.11 will make Python 3.8 a soft dependency for the controller. Ansible 2.12 will require Python3.8 or newer to function on the controller.

This deprecation warning will help inform users of this change.

ISSUE TYPE

Feature Pull Request

COMPONENT NAME

ADDITIONAL INFORMATION

changelogs/fragments/controller-python-warning.yml

lib/ansible/cli/scripts/ansible_cli_stub.py

lib/ansible/config/base.yml

samdoran · 2020-11-03T21:55:57Z

This should be mentioned in the docs as well: docs/docsite/rst/installation_guide/intro_installation.rst.

nitzmahone

Warning LGTM, though is this also the time/place to bump python_requires to 3.8?

gundalow · 2020-11-03T22:03:53Z

changelogs/fragments/controller-python-warning.yml

@@ -0,0 +1,3 @@
+minor_changes:


Should this be higher than minor so it's more prominent in the changelog?

The warning itself is minor

The policy change is major. The changelog & porting guides are reviewed by people before upgrading. Let's make sure we over-communicate these changes.

sivel · 2020-11-03T22:05:01Z

though is this also the time/place to bump python_requires to 3.8?

I'm concerned if we do that, fewer people will ever see the warning. But honestly, since we only plan to package DEB and RPM for 3.8+, I'd be fine with doing it in the python package too.

sivel · 2020-11-03T22:05:33Z

@samdoran docs entry added.

ansibot · 2020-11-03T22:56:15Z

The test ansible-test sanity --test pylint [explain] failed with 1 error:

lib/ansible/cli/scripts/ansible_cli_stub.py:77:12: ansible-deprecated-no-collection-name: No collection name found in call to Display.deprecated or AnsibleModule.deprecate

click here for bot help

docs/docsite/rst/installation_guide/intro_installation.rst

webknjaz · 2020-11-04T15:39:28Z

I'm concerned if we do that, fewer people will ever see the warning. But honestly, since we only plan to package DEB and RPM for 3.8+, I'd be fine with doing it in the python package too.

If we also add python_requires, close to 100% of the users won't ever see it. I don't know a single individual who would use pip's "ignore checks" args. Meaning that we could as well just go ahead and use py38 syntax.

webknjaz · 2020-11-04T15:41:22Z

Also, python_requires will only work if we'll actually ship wheels so that this metadata value would end up in the index and pip would actually see which versions are incompatible with the local env.

nitzmahone · 2020-11-04T19:02:09Z

@webknjaz the primary constraint on 3.8 for Ansible 2.11 is around split controller/remote testing in CI. We're assuming that won't be available until later in the 2.11 dev cycle, so rather than stopping all testing on everything < 3.8 until then, we just decided to do the "packaging/support only" requirement for 2.11.

sivel · 2020-11-06T18:34:35Z

setup.py

@@ -364,7 +364,7 @@ def get_dynamic_setup_params():
    license='GPLv3+',
    # Ansible will also make use of a system copy of python-six and
    # python-selectors2 if installed but use a Bundled copy if it's not.
-    python_requires='>=2.7,!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*,!=3.4.*',
+    python_requires='>=3.8',


I've gone ahead and added this change now. I can remove it, we can keep it, we can change it later. I'll discuss this with the other architects and confirm our plan.

pabelanger · 2020-11-06T18:39:25Z

Thank you, could we have a comment around testing? Just to confirm, would this mean testing for integration move to only py38?

Co-authored-by: Matt Clay <matt@mystile.com>

Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>

sivel · 2020-11-09T14:38:50Z

Thank you, could we have a comment around testing? Just to confirm, would this mean testing for integration move to only py38?

The big reason we are not making this a hard dep, by changing the code to require Python 3.8, is due to testing. What is on the roadmap for the 2.11 release is to implement split controller testing, where we can have different Python deps for the controller from that of the target.

Right now in our CI, the controller and target are the same host. Once ansible-test has this functionality we'll drop support for Python versions older than 3.8.

sivel · 2020-11-09T14:53:44Z

I'm merging this as is, without a python_requires change. If we decide to do that, we can do it later.

mattclay reviewed Nov 3, 2020

View reviewed changes

changelogs/fragments/controller-python-warning.yml Outdated Show resolved Hide resolved

lib/ansible/cli/scripts/ansible_cli_stub.py Outdated Show resolved Hide resolved

lib/ansible/config/base.yml Outdated Show resolved Hide resolved

nitzmahone reviewed Nov 3, 2020

View reviewed changes

gundalow reviewed Nov 3, 2020

View reviewed changes

ansibot added the docs This issue/PR relates to or includes documentation. label Nov 3, 2020

ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Nov 3, 2020

webknjaz reviewed Nov 3, 2020

View reviewed changes

docs/docsite/rst/installation_guide/intro_installation.rst Outdated Show resolved Hide resolved

sivel added this to In Progress in ansible-core 2.11 Nov 4, 2020

mattclay removed the needs_triage Needs a first human triage before being processed. label Nov 5, 2020

ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 5, 2020

sivel commented Nov 6, 2020

View reviewed changes

This comment has been minimized.

Sign in to view

ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Nov 6, 2020

sivel and others added 8 commits November 6, 2020 13:59

Emit warning when running on the controller with a Python older than 3.8

3aeed33

Add spaces

70f2a14

Co-authored-by: Matt Clay <matt@mystile.com>

and more spaces

aab0c64

Co-authored-by: Matt Clay <matt@mystile.com>

s/Py/Python/

98c53fc

Co-authored-by: Matt Clay <matt@mystile.com>

Add note to Control node requirements about Py3.8 requirement

61a736e

Add collection_name to deprecated call

2f416c5

more spaces

48860ee

Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>

Clarify that we are only packaging for py3.8+

9e2cadf

sivel force-pushed the controller-python-warning branch from c060a18 to 9e2cadf Compare November 6, 2020 20:00

ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 9, 2020

sivel merged commit 96ad5b7 into ansible:devel Nov 9, 2020

ansible-core 2.11 automation moved this from In Progress to Merged Nov 9, 2020

nitzmahone mentioned this pull request Nov 18, 2020

Bump ansible-core controller minimum to Python 3.8 #72668

Closed

ansible locked and limited conversation to collaborators Dec 7, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Emit warning when running on the controller with a Python older than 3.8 #72467

Emit warning when running on the controller with a Python older than 3.8 #72467

sivel commented Nov 3, 2020 •

edited

samdoran commented Nov 3, 2020

nitzmahone left a comment

gundalow Nov 3, 2020

webknjaz Nov 3, 2020

gundalow Nov 4, 2020

sivel commented Nov 3, 2020

sivel commented Nov 3, 2020

ansibot commented Nov 3, 2020

webknjaz commented Nov 4, 2020

webknjaz commented Nov 4, 2020

nitzmahone commented Nov 4, 2020 •

edited

sivel Nov 6, 2020

pabelanger commented Nov 6, 2020

This comment has been minimized.

sivel commented Nov 9, 2020

sivel commented Nov 9, 2020

Emit warning when running on the controller with a Python older than 3.8 #72467

Emit warning when running on the controller with a Python older than 3.8 #72467

Conversation

sivel commented Nov 3, 2020 • edited

SUMMARY

ISSUE TYPE

COMPONENT NAME

ADDITIONAL INFORMATION

samdoran commented Nov 3, 2020

nitzmahone left a comment

Choose a reason for hiding this comment

gundalow Nov 3, 2020

Choose a reason for hiding this comment

webknjaz Nov 3, 2020

Choose a reason for hiding this comment

gundalow Nov 4, 2020

Choose a reason for hiding this comment

sivel commented Nov 3, 2020

sivel commented Nov 3, 2020

ansibot commented Nov 3, 2020

webknjaz commented Nov 4, 2020

webknjaz commented Nov 4, 2020

nitzmahone commented Nov 4, 2020 • edited

sivel Nov 6, 2020

Choose a reason for hiding this comment

pabelanger commented Nov 6, 2020

This comment has been minimized.

sivel commented Nov 9, 2020

sivel commented Nov 9, 2020

sivel commented Nov 3, 2020 •

edited

nitzmahone commented Nov 4, 2020 •

edited