Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-2.10] [dnf] Some fixes around filtering (#72483) #72500

Merged
merged 2 commits into from
Nov 6, 2020
Merged

[stable-2.10] [dnf] Some fixes around filtering (#72483) #72500

merged 2 commits into from
Nov 6, 2020

Conversation

samdoran
Copy link
Contributor

@samdoran samdoran commented Nov 5, 2020

SUMMARY

Backport of #72483 for Ansible 2.10

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/modules/dnf.py

@relrod @samdoran
[stable-2.10] [dnf] Some fixes around filtering (ansible#72483)
cef6b12 
Change:
- Docs: Add note that security/bugfix apply to dependencies too, like
  the dnf command.

- dnf: security/bugfix only makes sense for updates, so limit the
  package query sack to available updates.

- tests: Limit tests to our known-good test packages, so that RHEL
  packages marked security/bugfix without similarly marked dependencies
  don't fail our tests.

Test Plan:
- Tested with `dnf upgrade-minimal --bugfix` and reproduced the same
  error currently seen in CI, showing that we are consistent with what
  dnf does.

Tickets:
- Likely fixes ansible#72316

Signed-off-by: Rick Elrod <rick@elrod.me>
(cherry picked from commit d8c637d)

Co-authored-by: Rick Elrod <rick@elrod.me>
@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. labels Nov 5, 2020
@samdoran
Add changelog (ansible#72502)
03c08ee 
(cherry picked from commit b33d7e2)
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. packaging Packaging category small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. support:community This issue/PR relates to code supported by the Ansible community. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed small_patch core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 5, 2020
@sivel sivel merged commit 8c5910e into ansible:stable-2.10 Nov 6, 2020
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Nov 6, 2020
@ansible ansible locked and limited conversation to collaborators Dec 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. packaging Packaging category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@samdoran @sivel @ansibot @relrod