Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add orig_exc context to error messages #72677

Merged
merged 2 commits into from
Nov 19, 2020
Merged

Conversation

sivel
Copy link
Member

@sivel sivel commented Nov 19, 2020

SUMMARY

Add orig_exc context to error messages. Fixes #68605

In 4befefd we added support for displaying extra context of the original exception. That change was too verbose, and we limited how and when orig_exc was used in 9c6d7dd, which ended up removing useful information.

This PR, adds some of that back slightly, to use the original message and the original exception to build a simple message

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
lib/ansible/errors/__init__.py
ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Nov 19, 2020
@ansibot

This comment has been minimized.

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Nov 19, 2020
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels Nov 19, 2020
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Nov 19, 2020
@jborean93 jborean93 merged commit 46198cf into ansible:devel Nov 19, 2020
@ansible ansible locked and limited conversation to collaborators Dec 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

import_task swallows AnsibleParserError
3 participants