Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update playbook_tests with type testing #72732

Merged
merged 4 commits into from Dec 20, 2021
Merged

Update playbook_tests with type testing #72732

merged 4 commits into from Dec 20, 2021

Conversation

JonTheNiceGuy
Copy link
Contributor

SUMMARY

Further to my research in https://jon.sprig.gs/blog/post/1801 this is a collection of tests used to determine types, rather than just using debug_type and listing a collection of types it might be!

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

+label: docsite_pr

ADDITIONAL INFORMATION

@ansibot
Copy link
Contributor

ansibot commented Nov 26, 2020

The test ansible-test sanity --test docs-build [explain] failed with 1 error:

docs/docsite/rst/user_guide/playbooks_filters.rst:96:0: undefined-label: undefined label: playbooks_tests#type-tests (if the link has no caption the label must precede a section header)

click here for bot help

@ansibot ansibot added affects_2.11 ci_verified Changes made in this PR are causing tests to fail. docs This issue/PR relates to or includes documentation. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 26, 2020
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Dec 1, 2020
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. pre_azp This PR was last tested before migration to Azure Pipelines. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Dec 9, 2020
@ansibot ansibot added the docs_only All changes are to files within the docs/docsite/ directory label Mar 28, 2021
Akasurde
Akasurde approved these changes Apr 27, 2021
View reviewed changes
Copy link
Member

@Akasurde Akasurde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will wait for others to comment.

@ansibot ansibot added the needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html label May 21, 2021
samccann
samccann reviewed Dec 15, 2021
View reviewed changes
Copy link
Contributor

@samccann samccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the incredibly long delay here! A couple of suggested edits (we prefer using code-blocks so the automated translation knows to ignore the example and not try to translate it). This also needs a rebase at this point because it took me so long to review!

docs/docsite/rst/user_guide/playbooks_tests.rst Outdated Show resolved Hide resolved
docs/docsite/rst/user_guide/playbooks_filters.rst Outdated Show resolved Hide resolved
@JonTheNiceGuy
Copy link
Contributor Author

I'll see if I can get these changes and the rebase done before New Year! Thanks for the review @samccann (even though it's late :) )

@JonTheNiceGuy
Update playbook_tests with type testing
82a5b2e 
Further to my research in https://jon.sprig.gs/blog/post/1801 this is a collection of tests used to determine types, rather than just using `debug_type` and listing a collection of types it might be!

- Docs Pull Request

+label: docsite_pr
@JonTheNiceGuy
Fixed RST issue
66ee951
@JonTheNiceGuy
Copy link
Contributor Author

Rebase done and fixes made. Thanks @samccann and @Akasurde

@ansibot ansibot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 16, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed pre_azp This PR was last tested before migration to Azure Pipelines. labels Dec 16, 2021
@ansibot
Copy link
Contributor

ansibot commented Dec 16, 2021

The test ansible-test sanity --test docs-build [explain] failed with 4 errors:

docs/docsite/rst/user_guide/playbooks_tests.rst:428:0: unexpected-indentation: Unexpected indentation.
docs/docsite/rst/user_guide/playbooks_tests.rst:445:0: unexpected-indentation: Unexpected indentation.
docs/docsite/rst/user_guide/playbooks_tests.rst:449:0: block-quote-missing-blank-line: Block quote ends without a blank line; unexpected unindent.
docs/docsite/rst/user_guide/playbooks_tests.rst:488:0: unexpected-indentation: Unexpected indentation.

The test ansible-test sanity --test rstcheck [explain] failed with 1 error:

docs/docsite/rst/user_guide/playbooks_tests.rst:428:0: Unexpected indentation.

click here for bot help

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Dec 16, 2021
@JonTheNiceGuy
Copy link
Contributor Author

Apologies, missed the code block comment - fixing that and testing it locally now.

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels Dec 16, 2021
@samccann
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Dec 20, 2021
@samccann samccann merged commit 47e2a26 into ansible:devel Dec 20, 2021
@samccann
Copy link
Contributor

Thanks @JonTheNiceGuy for the Ansible docs PR!

@JonTheNiceGuy JonTheNiceGuy deleted the patch-3 branch December 21, 2021 11:56
@ansible ansible locked and limited conversation to collaborators Jan 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Akasurde Akasurde Akasurde approved these changes

@samccann samccann samccann approved these changes

@acozine acozine Awaiting requested review from acozine

@lmalivert lmalivert Awaiting requested review from lmalivert

Assignees
No one assigned
Labels
affects_2.11 core_review In order to be merged, this PR must follow the core review workflow. docs_only All changes are to files within the docs/docsite/ directory docs This issue/PR relates to or includes documentation. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@JonTheNiceGuy @ansibot @samccann @Akasurde @samdoran