Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update WSL docs to mention sleep workaround #72839

Merged
merged 1 commit into from Dec 18, 2020
Merged

Update WSL docs to mention sleep workaround #72839

merged 1 commit into from Dec 18, 2020

Conversation

samdoran
Copy link
Contributor

@samdoran samdoran commented Dec 3, 2020

SUMMARY

Fixes #72156

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

docs/docsite/rst/user_guide/windows_faq.rst

@samdoran @jchambers-ln
Update WSL docs to mention sleep workaround
73843db 
Co-authored-by: Joseph Chambers <joe.chambers@lexisnexis.com>
@ansibot ansibot added affects_2.11 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community labels Dec 3, 2020
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Dec 8, 2020
jborean93
jborean93 approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@jborean93 jborean93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the content, not sure if this should be in a section about installing Ansible as windows_faq is probably more about targeting Windows. There is enough overlap that I don't really mind but the docs team should probably weigh in.

samccann
samccann approved these changes Dec 18, 2020
View reviewed changes
Copy link
Contributor

@samccann samccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and in the right place.

@samccann samccann merged commit 8fdb5ac into ansible:devel Dec 18, 2020
@ansible ansible locked and limited conversation to collaborators Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jborean93 jborean93 jborean93 approved these changes

@samccann samccann samccann approved these changes

Assignees
No one assigned
Labels
affects_2.11 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ansible on Windows 10 WSL running Ubuntu 20
5 participants
@samdoran @jborean93 @samccann @mkrizek @ansibot