Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.10] Improve deprecations #72871

Merged
merged 2 commits into from Dec 7, 2020
Merged

[2.10] Improve deprecations #72871

merged 2 commits into from Dec 7, 2020

Conversation

felixfontein
Copy link
Contributor

SUMMARY

Backport of #72697 to stable-2.10.

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME

core

@felixfontein
Improve deprecations (ansible#72697)
b3352e6 
* Remove space before comma in '... bla , use ...'

* 'why' is inserted in the middle of a sentence, between two commas.

* Make deprecations from base.yml show source ansible-core.

* Add changelog fragment.

* Improve some more 'why's.

* Add PR URL to fragment.

(cherry picked from commit f569d80)
@felixfontein
2.10 is ansible-base, not ansible-core
1692ad6
@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Dec 5, 2020
@relrod relrod merged commit 138a5bd into ansible:stable-2.10 Dec 7, 2020
@felixfontein felixfontein deleted the backport/2.10/72697 branch December 8, 2020 05:34
@felixfontein
Copy link
Contributor Author

@relrod also thanks for this one!

@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Dec 8, 2020
@ansible ansible locked and limited conversation to collaborators Jan 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@felixfontein @sivel @relrod @ansibot