Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unarchive: add support for .tar.zst (zstd compression) #73265

Merged
merged 2 commits into from Feb 10, 2021
Merged

unarchive: add support for .tar.zst (zstd compression) #73265

merged 2 commits into from Feb 10, 2021

Conversation

jsquyres
Copy link
Contributor

@jsquyres jsquyres commented Jan 16, 2021 •
edited

SUMMARY

Add support for .tar.zst (zstd compression) to the unarchive module

The zstd package for compression/decompression is readily available in many OS distributions. Its popularity is currently small, but is potentially growing due to its speed and compression ratios. Adding native support to unarchive to create / expand .tar.zst files is both straightforward and forward-looking to if/when .tar.zst becomes more common.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

unarchive

ADDITIONAL INFORMATION

This PR simply allows unarchive to transparently handle foo.tar.zst files.

Although GNU Tar does not natively support Zstd compression, this PR uses GNU Tar's -I CLI option to pass in the zstd executable to use for compression / decompression. Specifically: creating / expanding .tar.zst files requires that the zstd executable is available at the target.

@ansibot ansibot added affects_2.11 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. files Files category m:unarchive This issue/PR relates to the unarchive module. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jan 16, 2021
@jsquyres jsquyres force-pushed the pr/add-zst-to-unarchive branch 2 times, most recently from b124d1d to 38c403a Compare January 17, 2021 00:55
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels Jan 17, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels Jan 17, 2021
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. core_review In order to be merged, this PR must follow the core review workflow. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 17, 2021
@Shrews Shrews removed the needs_triage Needs a first human triage before being processed. label Jan 19, 2021
sivel
sivel requested changes Jan 19, 2021
View reviewed changes
lib/ansible/modules/unarchive.py Outdated Show resolved Hide resolved
@ansibot ansibot added needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 19, 2021
@ansibot ansibot added community_review In order to be merged, this PR must follow the community review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. community_review In order to be merged, this PR must follow the community review workflow. labels Jan 19, 2021
@jsquyres jsquyres requested a review from sivel January 20, 2021 14:36
@ansibot ansibot added support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed needs_maintainer Ansibot is unable to identify maintainers for this PR. (Check `author` in docs or BOTMETA.yml) labels Jan 20, 2021
@jsquyres
Copy link
Contributor Author

@sivel I made the requested change. Could you re-review? Thanks!

@jsquyres
Copy link
Contributor Author

jsquyres commented Feb 2, 2021

@sivel Anything else you need for a re-review? Thanks!

@ansibot ansibot added stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. labels Feb 2, 2021
@jsquyres
Copy link
Contributor Author

jsquyres commented Feb 9, 2021

Ping. Can someone review? I made the requested changes a few weeks ago. Thanks!

@relrod
Copy link
Member

relrod commented Feb 10, 2021

rebuild_merge

@ansibot ansibot added shipit This PR is ready to be merged by Core needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. stale_review Updates were made after the last review and the last review is more than 7 days old. shipit This PR is ready to be merged by Core labels Feb 10, 2021
@relrod relrod merged commit 6fd0a74 into ansible:devel Feb 10, 2021
@relrod
Copy link
Member

relrod commented Feb 10, 2021

@jsquyres sorry for the delay here, thanks for the patch!

@jsquyres
Copy link
Contributor Author

@relrod Thank you!

@jsquyres jsquyres deleted the pr/add-zst-to-unarchive branch February 10, 2021 14:11
@ansible ansible locked and limited conversation to collaborators Mar 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@relrod relrod relrod left review comments

@sivel sivel Awaiting requested review from sivel

Assignees
No one assigned
Labels
affects_2.11 feature This issue/PR relates to a feature request. files Files category m:unarchive This issue/PR relates to the unarchive module. module This issue/PR relates to a module. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_contributor This PR is the first contribution by a new community member. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jsquyres @relrod @sivel @Shrews @ansibot