Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mention that version_added should be collection version in collections #73270

Merged
merged 1 commit into from Jan 18, 2021
Merged

Mention that version_added should be collection version in collections #73270

merged 1 commit into from Jan 18, 2021
+7 −5

Conversation

felixfontein
Copy link
Contributor

SUMMARY

It currently says "The version of Ansible when the module was added." in some places.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

dev guide

@ansibot ansibot added affects_2.11 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. needs_triage Needs a first human triage before being processed. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jan 18, 2021
Andersson007
Andersson007 approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@Andersson007 Andersson007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it's also worth to backport it to 2.10, so that contributors see it on the "latest"'s page

@samccann samccann removed the needs_triage Needs a first human triage before being processed. label Jan 18, 2021
@samccann samccann merged commit 73aa571 into ansible:devel Jan 18, 2021
@felixfontein felixfontein deleted the fix-version_added-docs branch January 18, 2021 19:56
@felixfontein
Copy link
Contributor Author

@Andersson007 @samccann thanks for reviewing and merging!

felixfontein added a commit to felixfontein/ansible that referenced this pull request Jan 18, 2021
@felixfontein
Make sure to mention collection version for version_added as well. (a…
847fb50 
…nsible#73270)

(cherry picked from commit 73aa571)
@felixfontein felixfontein mentioned this pull request Jan 18, 2021
Merged
acozine pushed a commit that referenced this pull request Feb 3, 2021
@felixfontein
Make sure to mention collection version for version_added as well. (#…
dcec0ec 
…73270) (#73280)

(cherry picked from commit 73aa571)
@ansible ansible locked and limited conversation to collaborators Feb 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samccann samccann samccann approved these changes

@Andersson007 Andersson007 Andersson007 approved these changes

Assignees
No one assigned
Labels
affects_2.11 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. networking Network category support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@felixfontein @samccann @Andersson007 @ansibot