Bypass fragile git ssh wrapper unless really needed #73404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.11
bug
This comment has been minimized.
This comment has been minimized.
ansibot
added
needs_revision
jborean93
removed
the
needs_triage
ansibot
added
needs_revision
This comment has been minimized.
This comment has been minimized.
ansibot
added
needs_revision
bcoca
changed the title
ansibot
removed
the
needs_revision
ansibot
added
the
core_review
samdoran
added
the
ci_verified
ansibot
added
needs_revision
ansibot
added
the
stale_ci
ansibot
added
needs_ci
samdoran
added
the
ci_verified
ansibot
removed
the
ci_verified
mattclay
added
the
ci_verified
ansibot
added
the
stale_ci
ansibot
added
the
needs_rebase
ansibot
added
affects_2.13
and removed
ci_verified
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
git module now uses env vars exclusively
- updated docs to clarify usage
- now env vars append instead of overwrite to allow existing custom setups to keep working
fixes ansible#38104, ansible#64673, ansible#64674
- added note for hostkeychecking more securely
fixes ansible#69846
- keep script cause old versions still choke on env
- env var cannot hold more than 'command' for older versions
- all ssh_opts in one place
ansibot
added
the
needs_ci
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git module now uses env vars exclusively
fixes Git Module GIT_SSH Support #38104
fixes The git module should provide warning if the ssh_opts parameter is supplied but the version of git is 2.2.3 or earlier #64673
fixes Add warning if ssh_opts is present and git<2.3.0 #64674
fixes Git module: don't encourage MITM attacks #69846
ISSUE TYPE
COMPONENT NAME
modules/git.py