Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct pkg_mgr for Fedora-derived OSTree distros #73445

Merged
merged 1 commit into from Feb 2, 2021
Merged

Correct pkg_mgr for Fedora-derived OSTree distros #73445

merged 1 commit into from Feb 2, 2021

Conversation

relrod
Copy link
Member

@relrod relrod commented Feb 1, 2021

SUMMARY

Change:

  • Remove check that states that only Fedora can be an OSTree
    distribution.
  • This allows us to correctly return "atomic_container" as the pkg_mgr
    fact for RHEL for Edge, Fedora/RHEL/CentOS Atomic Host, etc.

Test Plan:

  • Created local RHEL for Edge image and tested against it.
  • Tested against regular RHEL 8 and still got dnf as expected.
  • Tested against RHEL 7 Atomic Host and got atomic_container now.
  • New unit tests.

Tickets:

Signed-off-by: Rick Elrod rick@elrod.me

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

pkg_mgr facts

@relrod
Correct pkg_mgr for Fedora-derived OSTree distros
1e2386e 
Change:
- Remove check that states that only Fedora can be an OSTree
  distribution.
- This allows us to correctly return "atomic_container" as the pkg_mgr
  fact for RHEL for Edge, Fedora/RHEL/CentOS Atomic Host, etc.

Test Plan:
- Created local RHEL for Edge image and tested against it.
- Tested against regular RHEL 8 and still got `dnf` as expected.
- Tested against RHEL 7 Atomic Host and got `atomic_container` now.
- New unit tests.

Tickets:
- Fixes ansible#73084

Signed-off-by: Rick Elrod <rick@elrod.me>
@relrod relrod marked this pull request as draft February 1, 2021 20:05
@ansibot ansibot added affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 1, 2021
@relrod
Copy link
Member Author

relrod commented Feb 1, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 1, 2021
@relrod relrod marked this pull request as ready for review February 2, 2021 04:20
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Feb 2, 2021
@samdoran samdoran merged commit 9a92723 into ansible:devel Feb 2, 2021
@ansible ansible locked and limited conversation to collaborators Mar 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samdoran samdoran samdoran approved these changes

@maxamillion maxamillion Awaiting requested review from maxamillion

Assignees
No one assigned
Labels
affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RHEL 8.3 Edge identifies wrong package manager
3 participants
@relrod @samdoran @ansibot