Fixed/improved regular expresssion for collection names

[russoz]

SUMMARY

The regexp to determine a collection name in schema.py:

COLLECTION_NAME_RE = re.compile('^([^.]+.[^.]+)$')

has two bugs: a) it does not protect the dot between names, allowing things like community#general or community%general or even communitygeneral to be validated, when they shouldn't, and b) it fails to validate namespaces with deeper directory structures.

While investigating this, simplified a regexp in lib/ansible/utils/collection_loader/_collection_finder.py as well

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

lib/ansible/utils/collection_loader/_collection_finder.py
test/lib/ansible_test/_data/sanity/validate-modules/validate_modules/schema.py

[sivel]

Related #73279

[samdoran]

This change looks correct at first glance, but it needs tests and a changelog fragment. See this fragment as an example.

[russoz]

@samdoran changelog fragment added.

[samdoran]

The changelog looks good. Can you please add some more tests cases to the existing unit tests?

ansible/test/units/utils/collection_loader/test_collection_loader.py

Lines 724 to 735 in f327e65

	('ns1.coll2', True),
	('def.coll3', False),
	('ns4.return', False),
	('assert.this', False),
	('import.that', False),
	('.that', False),
	('this.', False),
	('.', False),
	('', False),
	),
	)
	def test_fqcn_validation(fqcn, expected):

ansible/test/units/utils/collection_loader/test_collection_loader.py

Lines 743 to 747 in f327e65

	('no_dots_at_all_action', 'action', ValueError, 'is not a valid collection reference'),
	('no_nscoll.myaction', 'action', ValueError, 'is not a valid collection reference'),
	('ns.coll.myaction', 'bogus', ValueError, 'invalid collection ref_type'),
	])
	def test_fqcr_parsing_invalid(ref, ref_type, expected_error_type, expected_error_expression):

[russoz]

I love the smell of rebase in the morning

[russoz]

@samdoran added a couple of lines to the test data - not a big change so not much to add there.