Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention ansible-core @ "Release and maintenance" #73612

Conversation

webknjaz
Copy link
Member

SUMMARY

I noticed that
https://docs.ansible.com/ansible/devel/reference_appendices/release_and_maintenance.html only refers to ansible-base but since it's on devel, it should really acknowledge that it's ansible-core now.
This patch updates most of the references to use ansible-core.

ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
COMPONENT NAME

docs/docsite/rst/reference_appendices/release_and_maintenance.rst

ADDITIONAL INFORMATION

N/A

@ansibot ansibot added affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Feb 15, 2021

Collection updates (new modules, plugins, features and bugfixes) will always be integrated in what will become the next version of Ansible. This work is tracked within the individual collection repositories.

Ansible and ``ansible-base`` provide bugfixes and security improvements for the most recent major release. The previous
major release of ``ansible-base`` will only receive fixes for security issues and critical bugs.``ansible-base`` only applies
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also had a problem with no whitespace after "bugs." so the following inline highlighting didn't work.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, thanks for fixing that

@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Feb 17, 2021
Copy link
Contributor

@acozine acozine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good. My one concern is with all the newlines it introduces. Breaking up sentences like that is a challenge for automated translation software, so we'd like to keep paragraphs in the documentation as single lines whenever possible. Can you fix that @webknjaz? If not, we'll post a follow-up PR to do it.

@acozine acozine merged commit c22bc46 into ansible:devel Feb 23, 2021
@webknjaz
Copy link
Member Author

Ah, sorry, didn't notice the comment. Don't i18n tools work with sentences and paragraphs as opposed to lines?

@webknjaz webknjaz deleted the docs-bugfix/release-n-maintenance-core-not-base branch February 23, 2021 17:03
@ansible ansible locked and limited conversation to collaborators Mar 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants