Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipe it to connections #73688

Merged
merged 5 commits into from Feb 25, 2021
Merged

Pipe it to connections #73688

merged 5 commits into from Feb 25, 2021

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Feb 22, 2021 •
edited

moving pipeline config to the specific plugins.

also fixes #73672

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

connection

@ansibot ansibot added affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community labels Feb 22, 2021
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Feb 23, 2021
samdoran
samdoran suggested changes Feb 25, 2021
View reviewed changes
Copy link
Contributor

@samdoran samdoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. Can we add unit tests for this? The local connection plugin doesn't have very good coverage currently, though it does at least have a very basic unit test.

@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Feb 25, 2021
@bcoca
Copy link
Member Author

bcoca commented Feb 25, 2021

@sdoran the changes are coverd in generic set_options/get_option tests, i would not add a unit test per option per plugin.

@bcoca bcoca merged commit 9690512 into ansible:devel Feb 25, 2021
@bcoca bcoca deleted the pipeit branch February 25, 2021 20:08
bcoca added a commit to bcoca/ansible that referenced this pull request Mar 15, 2021
@bcoca
Pipe it to connections (ansible#73688)
e2a10e0 
* pipelining tweaks
  added 'defaults'  entry for ini pipelining from ssh plugin

(cherry picked from commit 9690512)
@ansible ansible locked and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samdoran samdoran samdoran requested changes

Assignees
No one assigned
Labels
affects_2.11 bug This issue/PR relates to a bug. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. new_plugin This PR includes a new plugin. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. windows Windows community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running commands on localhost hangs with sudo and pipelining since 2.10.6
3 participants
@bcoca @samdoran @ansibot