Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize ConfigParser between Python2 and Python3 #73715

Merged
merged 3 commits into from Feb 25, 2021

Conversation

sivel
Copy link
Member

@sivel sivel commented Feb 24, 2021

SUMMARY

Normalize ConfigParser between Python2 and Python3

Fixes #73709

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/config/manager.py

ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.11 bug This issue/PR relates to a bug. collection Related to Ansible Collections work collection:community.yang core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. python3 support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Feb 24, 2021
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Feb 24, 2021
@samdoran samdoran added the ci_verified Changes made in this PR are causing tests to fail. label Feb 24, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Feb 25, 2021
@sivel sivel merged commit 950ab74 into ansible:devel Feb 25, 2021
sivel added a commit to sivel/ansible that referenced this pull request Feb 25, 2021
…ible#73715)

* Normalize config parser between py2 and py3

* Add tests and changelog

* Use different config entry, since we supply certain env vars
(cherry picked from commit 950ab74)

Co-authored-by: Matt Martz <matt@sivel.net>
sivel added a commit to sivel/ansible that referenced this pull request Feb 25, 2021
…ble#73715)

* Normalize config parser between py2 and py3

* Add tests and changelog

* Use different config entry, since we supply certain env vars.
(cherry picked from commit 950ab74)

Co-authored-by: Matt Martz <matt@sivel.net>
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Feb 25, 2021
relrod pushed a commit that referenced this pull request Mar 8, 2021
…) (#73724)

* [stable-2.9] Normalize ConfigParser between Python2 and Python3 (#73715)

* Normalize config parser between py2 and py3

* Add tests and changelog

* Use different config entry, since we supply certain env vars.
(cherry picked from commit 950ab74)

Co-authored-by: Matt Martz <matt@sivel.net>
relrod pushed a commit that referenced this pull request Mar 8, 2021
) (#73723)

* [stable-2.10] Normalize ConfigParser between Python2 and Python3 (#73715)

* Normalize config parser between py2 and py3

* Add tests and changelog

* Use different config entry, since we supply certain env vars
(cherry picked from commit 950ab74)

* Update config entry
@ansible ansible locked and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.11 bug This issue/PR relates to a bug. collection:community.yang collection Related to Ansible Collections work core_review In order to be merged, this PR must follow the core review workflow. python3 support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration Settings example on docs.ansible.com produces error
4 participants