New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize ConfigParser between Python2 and Python3 #73715
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.11
bug
This issue/PR relates to a bug.
collection
Related to Ansible Collections work
collection:community.yang
core_review
In order to be merged, this PR must follow the core review workflow.
needs_triage
Needs a first human triage before being processed.
python3
support:community
This issue/PR relates to code supported by the Ansible community.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
labels
Feb 24, 2021
bcoca
reviewed
Feb 24, 2021
ansibot
added
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
and removed
core_review
In order to be merged, this PR must follow the core review workflow.
labels
Feb 24, 2021
samdoran
added
the
ci_verified
Changes made in this PR are causing tests to fail.
label
Feb 24, 2021
ansibot
added
core_review
In order to be merged, this PR must follow the core review workflow.
and removed
ci_verified
Changes made in this PR are causing tests to fail.
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
labels
Feb 25, 2021
bcoca
approved these changes
Feb 25, 2021
sivel
added a commit
to sivel/ansible
that referenced
this pull request
Feb 25, 2021
…ible#73715) * Normalize config parser between py2 and py3 * Add tests and changelog * Use different config entry, since we supply certain env vars (cherry picked from commit 950ab74) Co-authored-by: Matt Martz <matt@sivel.net>
sivel
added a commit
to sivel/ansible
that referenced
this pull request
Feb 25, 2021
…ble#73715) * Normalize config parser between py2 and py3 * Add tests and changelog * Use different config entry, since we supply certain env vars. (cherry picked from commit 950ab74) Co-authored-by: Matt Martz <matt@sivel.net>
bcoca
removed
the
needs_triage
Needs a first human triage before being processed.
label
Feb 25, 2021
relrod
pushed a commit
that referenced
this pull request
Mar 8, 2021
…) (#73724) * [stable-2.9] Normalize ConfigParser between Python2 and Python3 (#73715) * Normalize config parser between py2 and py3 * Add tests and changelog * Use different config entry, since we supply certain env vars. (cherry picked from commit 950ab74) Co-authored-by: Matt Martz <matt@sivel.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.11
bug
This issue/PR relates to a bug.
collection:community.yang
collection
Related to Ansible Collections work
core_review
In order to be merged, this PR must follow the core review workflow.
python3
support:community
This issue/PR relates to code supported by the Ansible community.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Normalize ConfigParser between Python2 and Python3
Fixes #73709
ISSUE TYPE
COMPONENT NAME
lib/ansible/config/manager.py
ADDITIONAL INFORMATION