Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move win_uri to a group that does not have another test using port 80 #73753

Merged

Conversation

samdoran
Copy link
Contributor

@samdoran samdoran commented Mar 1, 2021

SUMMARY

Another test in group3 reboots the test instance, killing the ssh connections needed for access to the httptest container.

The win_iis_webapppool test is using port 80 and this conflicts with the port httptest wants to use.

ISSUE TYPE
  • Test Pull Request
COMPONENT NAME

test/integration/targets/win_uri

Another test in group3 reboots the test instance, killing the ssh connections
needed for access to the httptest container.

ci_complete
@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 backport This PR does not target the devel branch. collection Related to Ansible Collections work collection:ansible.windows core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Mar 1, 2021
@jborean93
Copy link
Contributor

Isn't the ssh connection done when the win_uri test role is run? Any reboots before that shouldn't matter as last time I checked we batch the httptester connection setup.

@samdoran
Copy link
Contributor Author

samdoran commented Mar 1, 2021

I don think so, but I would have to double check. The win_uri test has been broken since I moved it to group3 from group6. group6 doesn't have any tests that call win_reboot but group3 does. So my guess was that rebooting the host before win_uri was killing the ssh port forwards.

@jborean93
Copy link
Contributor

jborean93 commented Mar 1, 2021

Hmm I swear this never mattered and before we split the majority of the tests out we would have had it in a group that would have had the reboot. It's never something that I've had to deal with before, although other group factors can break the httptester, just not reboots. Do you have a link to the error?

@samdoran
Copy link
Contributor Author

samdoran commented Mar 1, 2021

You are correct. It looks like we run pre_target = forward_ssh_ports and post_target = cleanup_ssh_ports for Windows integration tests. So I found the fix but not sure why that's the fix. 🤯

@jborean93
Copy link
Contributor

My guess is it's https://github.com/ansible/ansible/tree/stable-2.9/test/integration/targets/win_iis_webapppool as that installs IIS and we don't clean it up afterwards. This means that port 80 is being used by IIS and localhost:80 is going to IIS and not our forwarded httptester. I came across this before in the community.windows test.

@samdoran
Copy link
Contributor Author

samdoran commented Mar 1, 2021

You're reading my mind. :) I'm about to test with the combination of win_uri and win_iis_webapppool.

@samdoran samdoran changed the title Move win_uri to a group that does not reboot the test instance Move win_uri to a group that does not have another test using port 80 Mar 1, 2021
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Mar 1, 2021
@mattclay mattclay merged commit 5a9f4f7 into ansible:stable-2.9 Mar 1, 2021
@samdoran samdoran deleted the ci/rebalance-windows-stable-2.9-again branch March 1, 2021 21:35
@ansible ansible locked and limited conversation to collaborators Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.9 This issue/PR affects Ansible v2.9 backport This PR does not target the devel branch. collection:ansible.windows collection Related to Ansible Collections work core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants