Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.12] Add accept_newhostkey option to git module #73819

Merged
merged 5 commits into from
Apr 16, 2021
Merged

[2.12] Add accept_newhostkey option to git module #73819

merged 5 commits into from
Apr 16, 2021

Conversation

aminvakil
Copy link
Contributor

SUMMARY

Fixes: #69846

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

git

ADDITIONAL INFORMATION

This has been opened previously on #70499.

@ansibot ansibot added affects_2.11 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Mar 8, 2021
@aminvakil
Copy link
Contributor Author

/rebuild_failed

@aminvakil
Copy link
Contributor Author

ready_for_review

@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 8, 2021
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Mar 11, 2021
@mattclay mattclay changed the title Add accept_newhostkey option to git module [2.12] Add accept_newhostkey option to git module Mar 11, 2021
@bcoca bcoca added this to the 2.12 milestone Mar 11, 2021
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Mar 11, 2021
@ansibot
Copy link
Contributor

ansibot commented Mar 11, 2021

The test ansible-test sanity --test validate-modules [explain] failed with 1 error:

lib/ansible/modules/git.py:0:0: option-incorrect-version-added: version_added for new option (accept_newhostkey) should be '2.11'. Currently StrictVersion ('2.12')

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. labels Mar 11, 2021
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 19, 2021
@aminvakil
Copy link
Contributor Author

/rebuild_failed

@ansibot ansibot removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. ci_verified Changes made in this PR are causing tests to fail. labels Apr 7, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 7, 2021
@s-hertel s-hertel merged commit a7c8093 into ansible:devel Apr 16, 2021
@aminvakil aminvakil deleted the git_stricthostkeychecking branch April 16, 2021 15:12
@ansible ansible locked and limited conversation to collaborators May 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.11 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. module This issue/PR relates to a module. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
2.12
Development

Successfully merging this pull request may close these issues.

Git module: don't encourage MITM attacks
5 participants
@aminvakil @ansibot @mattclay @bcoca @s-hertel