Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly set path and fullpath for template vars #73924

Merged
merged 3 commits into from Mar 26, 2021
Merged

Correctly set path and fullpath for template vars #73924

merged 3 commits into from Mar 26, 2021

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Mar 16, 2021

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

tempalte

@ansibot ansibot added affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Mar 16, 2021
@bcoca
dont expect path to always be full path
fc9adb0 
 also added exception/tb on action fail
@bcoca
non
3a486ff
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 16, 2021
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Mar 16, 2021
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Mar 24, 2021
@bcoca
Copy link
Member Author

bcoca commented Mar 26, 2021

rebuild_merge

@ansibot ansibot added shipit This PR is ready to be merged by Core and removed core_review In order to be merged, this PR must follow the core review workflow. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Mar 26, 2021
@bcoca bcoca merged commit 22330dd into ansible:devel Mar 26, 2021
@bcoca bcoca deleted the depath_template branch March 26, 2021 20:33
bcoca added a commit to bcoca/ansible that referenced this pull request Mar 26, 2021
@bcoca
Correctly set path and fullpath for template vars (ansible#73924)
1da3d40 
* Correctly set path and fullpath for template vars

 don't expect path to always be full path
 also added exception/tb on action fail

(cherry picked from commit 22330dd)
@jborean93 jborean93 mentioned this pull request Mar 29, 2021
Merged
bcoca added a commit to bcoca/ansible that referenced this pull request Apr 6, 2021
@bcoca
Correctly set path and fullpath for template vars (ansible#73924)
08727ae 
* Correctly set path and fullpath for template vars

 don't expect path to always be full path
 also added exception/tb on action fail
@ansible ansible locked and limited conversation to collaborators Apr 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.11 bug This issue/PR relates to a bug. shipit This PR is ready to be merged by Core support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bcoca @mkrizek @ansibot