Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

less blocking on fact reading #73951

Merged
merged 5 commits into from Mar 23, 2021
Merged

less blocking on fact reading #73951

merged 5 commits into from Mar 23, 2021

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Mar 18, 2021

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

facts

@ansibot ansibot added affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Mar 18, 2021
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 18, 2021
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Mar 18, 2021
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 18, 2021
bcoca and others added 2 commits March 22, 2021 10:46
@bcoca @mkrizek
Update lib/ansible/module_utils/facts/utils.py
c5608b1 
Co-authored-by: Martin Krizek <martin.krizek@gmail.com>
@bcoca @mkrizek
Update lib/ansible/module_utils/facts/utils.py
b82bbd8 
Co-authored-by: Martin Krizek <martin.krizek@gmail.com>
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 22, 2021
@bcoca bcoca merged commit 232eeee into ansible:devel Mar 23, 2021
@bcoca bcoca deleted the less_block_facts branch March 23, 2021 14:28
bcoca added a commit to bcoca/ansible that referenced this pull request Apr 6, 2021
@bcoca @mkrizek
less blocking on fact reading (ansible#73951)
c41c79e 
* less blocking on fact reading


Co-authored-by: Martin Krizek <martin.krizek@gmail.com>
@ansible ansible locked and limited conversation to collaborators Apr 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bmillemathias bmillemathias bmillemathias left review comments

@Shrews Shrews Shrews approved these changes

@mkrizek mkrizek mkrizek approved these changes

Assignees
No one assigned
Labels
affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bcoca @bmillemathias @Shrews @mkrizek @mattclay @ansibot