Prevent traceback when task depth exceeds python recursion depth #73999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.11
bug
sivel
commented
Mar 22, 2021
ansibot
added
needs_revision
mkrizek
removed
the
needs_triage
webknjaz
reviewed
Mar 23, 2021
lib/ansible/playbook/base.py
Outdated
| try: | ||
| new_me = self.__class__() | ||
| except RuntimeError: | ||
| raise AnsibleError("Exceeded maximum object depth. This may have been caused by excessive role recursion.") |
There was a problem hiding this comment.
Try using six.reraise() here so that under py3 it'd show the previous exception trace
ansibot
added
core_review
|
The test |
ansibot
added
needs_revision
ansibot
added
core_review
ansibot
added
the
stale_ci
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ansibot
removed
the
stale_ci
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Prevent traceback when task depth exceeds python recursion depth. Fixes #73996
ISSUE TYPE
COMPONENT NAME
lib/ansible/playbook/base.py
ADDITIONAL INFORMATION