Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 2.12 roadmap #74000

Merged
merged 6 commits into from
Apr 6, 2021
Merged

Add 2.12 roadmap #74000

merged 6 commits into from
Apr 6, 2021

Conversation

sivel
Copy link
Member

@sivel sivel commented Mar 22, 2021

SUMMARY

Add 2.12 roadmap

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

docs/docsite/rst/roadmap/ROADMAP_2_12.rst

ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Mar 22, 2021
@Andersson007 Andersson007 mentioned this pull request Mar 23, 2021
Closed
ssbarnea
ssbarnea reviewed Mar 23, 2021
View reviewed changes
docs/docsite/rst/roadmap/ROADMAP_2_12.rst
- 2021-10-04 Release Candidate 1 (and ``stable-2.12`` branching from ``devel``)
- 2021-10-11 Release Candidate 2 (if necessary)

- 2021-10-25 Release
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only 5 weeks between first pre-release and the release? IMHO, that is too little. I would personally like to see prerelease on pypi appearing at least 2 months before the release.

If there is a feature freeze, why there is no package published for it?

Based on my experience very few people are testing pre-releases and even fewer are testing code from devel branch.

For several Ansible related projects I do have CI/CD pipelines which test prereleases of dependencies, which allow us to find breakages. Still for this to function we need to make the pre-release publishing something common, I would argue that as common as patch-releases on stable branches.

docs/docsite/rst/roadmap/ROADMAP_2_12.rst Show resolved Hide resolved
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Mar 23, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. docs_only All changes are to files within the docs/docsite/ directory and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 23, 2021
@ansibot
Copy link
Contributor

ansibot commented Mar 23, 2021

The test ansible-test sanity --test docs-build [explain] failed with 1 error:

docs/docsite/rst/roadmap/ROADMAP_2_12.rst:0:0: not-in-toc-tree: document isn't included in any toctree

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Mar 23, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 23, 2021
@ansibot
Copy link
Contributor

ansibot commented Mar 23, 2021

The test ansible-test sanity --test docs-build [explain] failed with 2 errors:

docs/docsite/rst/index.rst:86:0: toc-tree-missing-document: toctree contains reference to nonexisting document 'roadmap/ansible_base_roadmap_index'
docs/docsite/rst/roadmap/ansible_core_roadmap_index.rst:0:0: not-in-toc-tree: document isn't included in any toctree

click here for bot help

@ansibot ansibot removed the core_review In order to be merged, this PR must follow the core review workflow. label Mar 23, 2021
@ansibot ansibot added the needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. label Mar 23, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 23, 2021
samccann
samccann reviewed Mar 25, 2021
View reviewed changes
Copy link
Contributor

@samccann samccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are changing the filename, you'll also need to change it here:
https://github.com/ansible/ansible/blob/devel/docs/docsite/sphinx_conf/ansible_conf.py#L101

@sivel
Copy link
Member Author

sivel commented Mar 25, 2021

If you are changing the filename, you'll also need to change it here:
https://github.com/ansible/ansible/blob/devel/docs/docsite/sphinx_conf/ansible_conf.py#L101

Done.

samccann
samccann approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@samccann samccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Are we waiting on any other reviews or can this be merged?

@sivel
Copy link
Member Author

sivel commented Mar 26, 2021

Are we waiting on any other reviews or can this be merged?

I'm waiting on more reviews. I'll merge when ready.

@sivel sivel merged commit 09c8fac into ansible:devel Apr 6, 2021
webknjaz
webknjaz reviewed Apr 7, 2021
View reviewed changes
docs/docsite/rst/core_index.rst
@@ -87,4 +87,4 @@ This documentation covers the version of ``ansible-core`` noted in the upper lef
:maxdepth: 2
:caption: Roadmaps

roadmap/ansible_base_roadmap_index.rst
roadmap/ansible_core_roadmap_index.rst
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FTR the .rst suffix is unnecessary in doctrees. It's better to drop it in the future.

@ansible ansible locked and limited conversation to collaborators May 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ssbarnea ssbarnea ssbarnea left review comments

@webknjaz webknjaz webknjaz approved these changes

@thaumos thaumos thaumos approved these changes

@samccann samccann samccann approved these changes

@nitzmahone nitzmahone Awaiting requested review from nitzmahone

Assignees
No one assigned
Labels
affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. docs_only All changes are to files within the docs/docsite/ directory docs This issue/PR relates to or includes documentation. has_issue support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sivel @ansibot @ssbarnea @webknjaz @thaumos @samccann @mkrizek