Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nonzero exit code on ansible-galaxy collection verify failures #74051

Merged
merged 1 commit into from Mar 29, 2021
Merged

nonzero exit code on ansible-galaxy collection verify failures #74051

merged 1 commit into from Mar 29, 2021

Conversation

nitzmahone
Copy link
Member

@nitzmahone nitzmahone commented Mar 27, 2021 •
edited

SUMMARY

ansible-galaxy collection verify will now exit with a non-zero error code on verification failures.

ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME

ansible-galaxy CLI

ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.11 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Mar 27, 2021
@nitzmahone nitzmahone marked this pull request as draft March 27, 2021 00:07
@nitzmahone nitzmahone added this to In Progress in ansible-core 2.11 Mar 27, 2021
@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Mar 27, 2021
@nitzmahone nitzmahone mentioned this pull request Mar 27, 2021
Merged
@webknjaz webknjaz self-requested a review March 27, 2021 00:23
@nitzmahone nitzmahone marked this pull request as ready for review March 29, 2021 18:07
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. labels Mar 29, 2021
@ansible ansible deleted a comment from ansibot Mar 29, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 29, 2021
@nitzmahone nitzmahone merged commit 454c7e3 into ansible:devel Mar 29, 2021
ansible-core 2.11 automation moved this from In Progress to Merged Mar 29, 2021
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Mar 30, 2021
bcoca pushed a commit to bcoca/ansible that referenced this pull request Apr 6, 2021
@nitzmahone @bcoca
nonzero exit code on ansible galaxy collection verify failures (ans…
ef02e43 
…ible#74051)
@ansible ansible locked and limited conversation to collaborators Apr 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@webknjaz webknjaz Awaiting requested review from webknjaz

Assignees
No one assigned
Labels
affects_2.11 core_review In order to be merged, this PR must follow the core review workflow. feature This issue/PR relates to a feature request. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
No open projects
ansible-core 2.11
  
Merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nitzmahone @webknjaz @bcoca @ansibot