Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comment in iptables unit test #74061

Merged
merged 3 commits into from Mar 30, 2021
Merged

Fix comment in iptables unit test #74061

merged 3 commits into from Mar 30, 2021

Conversation

aminvakil
Copy link
Contributor

SUMMARY

I've just noticed there has been a mistake in my previous PR for iptables unit test in c1da427

This little patch fixes the comment of unit test.

ISSUE TYPE
  • Test Pull Request
COMPONENT NAME

iptables

@ansibot ansibot added affects_2.11 core_review In order to be merged, this PR must follow the core review workflow. docs_only All changes are to files within the docs/docsite/ directory needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. and removed docs_only All changes are to files within the docs/docsite/ directory labels Mar 29, 2021
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Mar 30, 2021
@aminvakil
Revert "Add changelog"
3da0226 
This reverts commit a4d98e4.
@ansibot ansibot added the docs_only All changes are to files within the docs/docsite/ directory label Mar 30, 2021
@aminvakil
Copy link
Contributor Author

ready_for_review

@samdoran samdoran merged commit 846c2d1 into ansible:devel Mar 30, 2021
@aminvakil aminvakil deleted the iptables_unit_test_fix_comment branch March 31, 2021 09:14
bcoca pushed a commit to bcoca/ansible that referenced this pull request Apr 6, 2021
@aminvakil @bcoca
Fix comment in iptables unit test (ansible#74061)
cae20d0
@ansible ansible locked and limited conversation to collaborators Apr 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samdoran samdoran samdoran approved these changes

Assignees
No one assigned
Labels
affects_2.11 core_review In order to be merged, this PR must follow the core review workflow. docs_only All changes are to files within the docs/docsite/ directory support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aminvakil @samdoran @ansibot