Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix debug factsetter #74067

Merged
merged 6 commits into from Mar 31, 2021
Merged

Fix debug factsetter #74067

merged 6 commits into from Mar 31, 2021

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Mar 30, 2021

fixes #74060

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ansible_facts

@ansibot ansibot added affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Mar 30, 2021
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Mar 30, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 30, 2021
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Mar 30, 2021
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Mar 30, 2021
@ansible ansible deleted a comment from ansibot Mar 30, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels Mar 30, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Mar 31, 2021
@bcoca bcoca merged commit f9f839f into ansible:devel Mar 31, 2021
@bcoca bcoca deleted the fix_debug_factsetter branch March 31, 2021 13:32
bcoca added a commit to bcoca/ansible that referenced this pull request Mar 31, 2021
@bcoca
Fix debug factsetter (ansible#74067)
4ed0cf8 
* prevent debug from setting namespaced facts as tlv
* also added tests

(cherry picked from commit f9f839f)
relrod added a commit that referenced this pull request Apr 5, 2021
@bcoca @relrod
Fix debug factsetter (#74067) (#74084)
adae63e 
* Fix debug factsetter (#74067)

* prevent debug from setting namespaced facts as tlv
* also added tests

(cherry picked from commit f9f839f)

* Update debug_dont_set_facts.yml

Co-authored-by: Rick Elrod <rick@elrod.me>
bcoca added a commit to bcoca/ansible that referenced this pull request Apr 6, 2021
@bcoca
Fix debug factsetter (ansible#74067)
cc17eac 
* prevent debug from setting namespaced facts as tlv
* also added tests
@ansible ansible locked and limited conversation to collaborators Apr 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkrizek mkrizek mkrizek approved these changes

@samdoran samdoran samdoran approved these changes

Assignees
No one assigned
Labels
affects_2.11 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Debug of ansible_facts causes injection of unprefixed variables
4 participants
@bcoca @mkrizek @samdoran @ansibot