Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a file-like obj for stdout/stderr for deadlock workaround #74156

Merged
merged 1 commit into from Apr 6, 2021
Merged

Use a file-like obj for stdout/stderr for deadlock workaround #74156

merged 1 commit into from Apr 6, 2021
+3 −2

Conversation

mkrizek
Copy link
Contributor

@mkrizek mkrizek commented Apr 6, 2021

SUMMARY

Fixes #74149

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/executor/process/worker.py

@mkrizek mkrizek added the P1 Priority 1 - Immediate Attention Required; Release Immediately After Fixed label Apr 6, 2021
@mkrizek mkrizek requested a review from sivel April 6, 2021 14:23
sivel
sivel approved these changes Apr 6, 2021
View reviewed changes
Copy link
Member

@sivel sivel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😞

@ansibot ansibot added affects_2.12 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 6, 2021
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label Apr 6, 2021
@sivel
Copy link
Member

sivel commented Apr 6, 2021

I've confirmed that this still fixes the issue I could reliably reproduce.

@sivel sivel merged commit 96f94c0 into ansible:devel Apr 6, 2021
@mkrizek mkrizek deleted the dead-worker35-74149 branch April 6, 2021 16:36
mkrizek added a commit to mkrizek/ansible that referenced this pull request Apr 6, 2021
@mkrizek
Use a file-like obj for stdout/stderr for deadlock workaround (ansibl…
8e286e7 
…e#74156)

Fixes ansible#74149

(cherry picked from commit 96f94c0)
@mkrizek mkrizek mentioned this pull request Apr 6, 2021
Merged
relrod pushed a commit that referenced this pull request Apr 6, 2021
@mkrizek
Use a file-like obj for stdout/stderr for deadlock workaround (#74156) (
f196914 
#74160)

Fixes #74149

(cherry picked from commit 96f94c0)
@ansible ansible locked and limited conversation to collaborators May 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sivel sivel sivel approved these changes

Assignees
No one assigned
Labels
affects_2.12 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. P1 Priority 1 - Immediate Attention Required; Release Immediately After Fixed support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python 3.5: 'ERROR! A worker was found in a dead state' showing up a lot more often
3 participants
@mkrizek @sivel @ansibot