Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[playbook] error on empty, error on 'include' (remove two deprecations) #74172

Merged
merged 2 commits into from
Apr 9, 2021
Merged

[playbook] error on empty, error on 'include' (remove two deprecations) #74172

merged 2 commits into from
Apr 9, 2021

Conversation

relrod
Copy link
Member

@relrod relrod commented Apr 7, 2021

SUMMARY

Change:

  • Remove two deprecated features
  • We now error if a playbook is an empty list instead of just skipping
  • We now error if using 'include' instead of 'import_playbook'

Test Plan:

  • Added new tests for new errors

Tickets:

Signed-off-by: Rick Elrod rick@elrod.me

ISSUE TYPE
  • Bugfix Pull Request
  • Feature Pull Request
COMPONENT NAME

playbook

@relrod
[playbook] error on empty, error on 'include'
6f890cc 
Change:
- Remove two deprecated features
- We now error if a playbook is an empty list instead of just skipping
- We now error if using 'include' instead of 'import_playbook'

Test Plan:
- Added new tests for new errors

Tickets:
- Fixes ansible#74133

Signed-off-by: Rick Elrod <rick@elrod.me>
@ansibot ansibot added affects_2.12 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 7, 2021
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Apr 7, 2021
@relrod
sanity & changelog
c7e07c1 
Signed-off-by: Rick Elrod <rick@elrod.me>
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. test This PR relates to tests. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 7, 2021
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Apr 8, 2021
@relrod relrod requested review from bcoca and samdoran April 8, 2021 20:05
@samdoran samdoran merged commit ef554d0 into ansible:devel Apr 9, 2021
@ansible ansible locked and limited conversation to collaborators May 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samdoran samdoran samdoran approved these changes

@bcoca bcoca Awaiting requested review from bcoca

Assignees
No one assigned
Labels
affects_2.12 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

playbook contains deprecated call to be removed in 2.12
3 participants
@relrod @ansibot @samdoran