Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fallback to devnull when trying to preserve stdin in worker #74192

Merged
merged 1 commit into from
Apr 15, 2021
Merged

Fix fallback to devnull when trying to preserve stdin in worker #74192

merged 1 commit into from
Apr 15, 2021

Conversation

mkrizek
Copy link
Contributor

@mkrizek mkrizek commented Apr 8, 2021

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/executor/process/worker.py

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.12 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 8, 2021
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Apr 8, 2021
@mkrizek mkrizek marked this pull request as ready for review April 9, 2021 07:45
@mkrizek mkrizek requested review from bcoca and sivel April 9, 2021 07:46
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. labels Apr 9, 2021
@mkrizek mkrizek merged commit 3cbe16f into ansible:devel Apr 15, 2021
@mkrizek mkrizek deleted the fix-fork-stdin-fallback branch April 15, 2021 08:14
@ansible ansible locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sivel sivel sivel approved these changes

@bcoca bcoca Awaiting requested review from bcoca

Assignees
No one assigned
Labels
affects_2.12 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mkrizek @sivel @samdoran @ansibot