Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

various fixes to command #74212

Merged
merged 10 commits into from
Apr 13, 2021
Merged

various fixes to command #74212

merged 10 commits into from
Apr 13, 2021

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Apr 9, 2021

  • Updated splitter to allow for all expected args in ad-hoc
  • Ensure we always return the returns we promissed to always return (i.e stderr/stdout)
  • Updated docs to clarify creates/removes precdence in checking
  • Removed abspath from chdir to allow reporting to handle symlinks correctly

fixes #39216
fixes #40711
fixes #41355
fixes #47517
fixes #55918

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

modules/command.py

@ansibot ansibot added affects_2.12 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Apr 9, 2021
@samdoran samdoran added the ci_verified Changes made in this PR are causing tests to fail. label Apr 9, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 12, 2021
@ansibot ansibot added the support:community This issue/PR relates to code supported by the Ansible community. label Apr 12, 2021
@bcoca
various fixes to command
fc0c2fd 
  - Updated splitter to allow for all expected args in ad-hoc
  - Ensure we always return the returns we promissed to always return (i.e stderr/stdout)
  - Updated docs to clarify creates/removes precdence in checking
  - Removed abspath from chdir to allow reporting to handle symlinks correctly
  - Corrected tests to new output messages
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 12, 2021
felixfontein
felixfontein reviewed Apr 12, 2021
View reviewed changes
lib/ansible/modules/command.py Outdated Show resolved Hide resolved
lib/ansible/modules/command.py Outdated Show resolved Hide resolved
lib/ansible/modules/command.py Show resolved Hide resolved
bcoca and others added 3 commits April 12, 2021 12:27
@bcoca
added clog note as per felix feedback
a2866a2
@bcoca @felixfontein
Update lib/ansible/modules/command.py
030bc99 
Co-authored-by: Felix Fontein <felix@fontein.de>
@bcoca @felixfontein
Update lib/ansible/modules/command.py
95f160f 
Co-authored-by: Felix Fontein <felix@fontein.de>
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Apr 12, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 12, 2021
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 12, 2021
@eqrx eqrx added the ci_verified Changes made in this PR are causing tests to fail. label Apr 12, 2021
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Apr 12, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 12, 2021
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label Apr 13, 2021
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 13, 2021
@bcoca bcoca merged commit b3b1dde into ansible:devel Apr 13, 2021
@bcoca bcoca deleted the command_fixes branch April 13, 2021 16:52
bcoca added a commit to bcoca/ansible that referenced this pull request Apr 13, 2021
@bcoca
various fixes to command (ansible#74212)
3951907 
* various fixes to command

  - Updated splitter to allow for all expected args in ad-hoc
  - Ensure we always return the returns we promissed to always return (i.e stderr/stdout)
  - Updated docs to clarify creates/removes precdence in checking
  - Removed abspath from chdir to allow reporting to handle symlinks correctly
  - Corrected tests to new output messages

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit b3b1dde)
bcoca added a commit to bcoca/ansible that referenced this pull request Apr 13, 2021
@bcoca
various fixes to command (ansible#74212)
75b301f 
* various fixes to command

  - Updated splitter to allow for all expected args in ad-hoc
  - Ensure we always return the returns we promissed to always return (i.e stderr/stdout)
  - Updated docs to clarify creates/removes precdence in checking
  - Removed abspath from chdir to allow reporting to handle symlinks correctly
  - Corrected tests to new output messages

Co-authored-by: Felix Fontein <felix@fontein.de>
(cherry picked from commit b3b1dde)
@ansible ansible locked and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@felixfontein felixfontein felixfontein left review comments

Assignees
No one assigned
Labels
affects_2.12 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. module This issue/PR relates to a module. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
5 participants
@bcoca @felixfontein @samdoran @ansibot @eqrx