[controller ansiballz] escape directory regex

[relrod]

SUMMARY

Change:

• We were passing a directory name directly to re.compile().
  If the directory isn't valid regex (or is) this can have odd side
  effects, such as crashing.

Test Plan:

• None yet, how do I test this?

Signed-off-by: Rick Elrod rick@elrod.me

Without this:

ERROR! Unexpected Exception, this is probably a bug: unterminated character set at position 31
the full traceback was:

Traceback (most recent call last):
  File "/Users/rick/dev/ansible/ansible[devel/bin/ansible", line 123, in <module>
    exit_code = cli.run()
  File "/Users/rick/dev/ansible/ansible[devel/lib/ansible/cli/adhoc.py", line 166, in run
    result = self._tqm.run(play)
  File "/Users/rick/dev/ansible/ansible[devel/lib/ansible/executor/task_queue_manager.py", line 261, in run
    strategy = strategy_loader.get(new_play.strategy, self)
  File "/Users/rick/dev/ansible/ansible[devel/lib/ansible/plugins/loader.py", line 547, in get
    name, path = self.find_plugin_with_name(name, collection_list=collection_list)
  File "/Users/rick/dev/ansible/ansible[devel/lib/ansible/plugins/loader.py", line 414, in find_plugin_with_name
    return name, self._find_plugin_legacy(name, ignore_deprecated, check_aliases, suffix)
  File "/Users/rick/dev/ansible/ansible[devel/lib/ansible/plugins/loader.py", line 439, in _find_plugin_legacy
    for path in (p for p in self._get_paths() if p not in self._searched_paths and os.path.isdir(p)):
  File "/Users/rick/dev/ansible/ansible[devel/lib/ansible/plugins/loader.py", line 255, in _get_paths
    ret.extend(self._get_package_paths(subdirs=subdirs))
  File "/Users/rick/dev/ansible/ansible[devel/lib/ansible/plugins/loader.py", line 220, in _get_package_paths
    m = __import__(self.package)
  File "/Users/rick/dev/ansible/ansible[devel/lib/ansible/plugins/strategy/__init__.py", line 38, in <module>
    from ansible.executor.process.worker import WorkerProcess
  File "/Users/rick/dev/ansible/ansible[devel/lib/ansible/executor/process/worker.py", line 39, in <module>
    from ansible.executor.task_executor import TaskExecutor
  File "/Users/rick/dev/ansible/ansible[devel/lib/ansible/executor/task_executor.py", line 20, in <module>
    from ansible.executor.module_common import get_action_args_with_defaults
  File "/Users/rick/dev/ansible/ansible[devel/lib/ansible/executor/module_common.py", line 417, in <module>
    CORE_LIBRARY_PATH_RE = re.compile(r'%s/(?P<path>ansible/modules/.*)\.py$' % site_packages)
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/re.py", line 250, in compile
    return _compile(pattern, flags)
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/re.py", line 302, in _compile
    p = sre_compile.compile(pattern, flags)
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/sre_compile.py", line 764, in compile
    p = sre_parse.parse(p, flags)
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/sre_parse.py", line 948, in parse
    p = _parse_sub(source, state, flags & SRE_FLAG_VERBOSE, 0)
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/sre_parse.py", line 443, in _parse_sub
    itemsappend(_parse(source, state, verbose, nested + 1,
  File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.8/lib/python3.8/sre_parse.py", line 549, in _parse
    raise source.error("unterminated character set",
re.error: unterminated character set at position 31

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

ansiballz but controller side

[bcoca]

do you have a test case to trigger this?

[relrod]

I am able to trigger it locally (moving my clone of the repo to ansible[foo will trigger it). I don't know if it's possible to write a test case that does that, I need to discuss with mattclay.