Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ansible-test coverage traceback when no data. #74357

Merged
merged 1 commit into from
Apr 20, 2021
Merged

Fix ansible-test coverage traceback when no data. #74357

merged 1 commit into from
Apr 20, 2021

Conversation

mattclay
Copy link
Member

SUMMARY

If no coverage directory exists, ansible-test coverage would traceback.

Now it silently continues just as if the directory was present but empty.

ISSUE TYPE

Bugfix Pull Request

COMPONENT NAME

ansible-test

ADDITIONAL INFORMATION

Fixes the traceback reported in #74350

@mattclay
Fix ansible-test coverage traceback when no data.
5cf58a6 
If no coverage directory exists, ansible-test coverage would traceback.

Now it silently continues just as if the directory was present but empty.
@mattclay mattclay mentioned this pull request Apr 20, 2021
Closed
1 task
@ansibot ansibot added affects_2.12 bug This issue/PR relates to a bug. has_issue needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Apr 20, 2021
@mattclay mattclay removed the needs_triage Needs a first human triage before being processed. label Apr 20, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 20, 2021
@mattclay mattclay merged commit e6af2d6 into ansible:devel Apr 20, 2021
@mattclay mattclay deleted the at-coverage-traceback branch April 20, 2021 21:33
@ansible ansible locked and limited conversation to collaborators May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.12 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. has_issue support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mattclay @ansibot