Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing delegate display #74370

Merged
merged 6 commits into from Apr 28, 2021
Merged

Fix missing delegate display #74370

merged 6 commits into from Apr 28, 2021

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Apr 21, 2021 •
edited

also improved with ansible_host + orig host display and noop ignore

fixes #74071
see #74371 for backportable version

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

callback

@ansibot ansibot added affects_2.12 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 21, 2021
@bcoca bcoca force-pushed the fix_missing_delegate_display branch from cbc8354 to 233e12e Compare April 21, 2021 19:21
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Apr 22, 2021
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Apr 22, 2021
@samdoran samdoran added the ci_verified Changes made in this PR are causing tests to fail. label Apr 23, 2021
@bcoca bcoca force-pushed the fix_missing_delegate_display branch from 233e12e to eaa5bad Compare April 27, 2021 20:17
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed ci_verified Changes made in this PR are causing tests to fail. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels Apr 27, 2021
@bcoca bcoca merged commit 3cff54d into ansible:devel Apr 28, 2021
@bcoca bcoca deleted the fix_missing_delegate_display branch April 28, 2021 17:25
samdoran added a commit to samdoran/ansible that referenced this pull request May 3, 2021
@samdoran
Revert "Fix missing delegate display (ansible#74370)"
62a2aeb 
This reverts commit 3cff54d.
@ansible ansible locked and limited conversation to collaborators May 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nitzmahone nitzmahone nitzmahone left review comments

@agaffney agaffney agaffney approved these changes

Assignees
No one assigned
Labels
affects_2.12 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delegation not properly shown in task
5 participants
@bcoca @agaffney @nitzmahone @samdoran @ansibot