Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix combinated run of unarchive and uri tests under centos 6 #74386

Merged
merged 1 commit into from
Apr 23, 2021
Merged

Fix combinated run of unarchive and uri tests under centos 6 #74386

merged 1 commit into from
Apr 23, 2021

Conversation

eqrx
Copy link
Contributor

@eqrx eqrx commented Apr 22, 2021

SUMMARY

The unarchive integration test installs pinned packages via pip,
the uri test installs them from system packages. This explodes.
PR lets unarchive uninstall packages after test ran.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • unarchive
  • uri
ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.12 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Apr 22, 2021
@ansibot
Copy link
Contributor

ansibot commented Apr 22, 2021

The test ansible-test sanity --test yamllint [explain] failed with 1 error:

test/integration/targets/unarchive/tasks/test_download.yml:41:1: empty-lines: too many blank lines (1 > 0)

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Apr 22, 2021
@eqrx eqrx requested a review from mattclay April 22, 2021 19:16
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 22, 2021
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Apr 22, 2021
@eqrx
Fix combinated run of unarchive and uri tests under centos 6
6d1ee21 
The unarchive integration test installs pinned packages via pip,
the uri test installs them from system packages. This explodes.
PR lets unarchive uninstall packages after test ran.
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Apr 22, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Apr 22, 2021
@mattclay mattclay merged commit ff88a2a into ansible:devel Apr 23, 2021
@eqrx eqrx deleted the centos6testfix branch April 27, 2021 16:08
@ansible ansible locked and limited conversation to collaborators May 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mattclay mattclay mattclay approved these changes

Assignees
No one assigned
Labels
affects_2.12 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eqrx @ansibot @mattclay @bcoca