The apt_key module did not properly handle GnuPG errors for certain actions #74478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.12
module
maximmasiutin
force-pushed
the
gpg-error-check
branch
from
281539e
to
a08c70d
Compare
1 task
|
ready_for_review |
ansibot
added
has_issue
core_review
samdoran
removed
the
needs_triage
ansibot
removed
the
new_contributor
samdoran
suggested changes
Apr 29, 2021
ansibot
added
needs_revision
maximmasiutin
force-pushed
the
gpg-error-check
branch
from
0d03072
to
b6dca88
Compare
ansibot
added
core_review
…nt GnuPG error information was returned by the 'ansible.builtin.apt_key' module (ansible#74477)
maximmasiutin
force-pushed
the
gpg-error-check
branch
from
e980d97
to
695cab6
Compare
ansibot
removed
the
needs_revision
ansibot
added
core_review
samdoran
reviewed
Apr 30, 2021
Co-authored-by: Sam Doran <sdoran@redhat.com>
ansibot
added
the
needs_ci
samdoran
approved these changes
Apr 30, 2021
samdoran
changed the title
ansibot
added
core_review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Not all GnuPG return codes are analyzed (rc != 0) by the 'ansible.builtin.apt_key' module.
ISSUE TYPE
COMPONENT NAME
ansible.builtin.apt_keyADDITIONAL INFORMATION
Fixes: #74477
@Akasurde - please review
I expected all calls of the 'gpg' binary have accompanying checks of the rc code. And if (rc != 0), then all relevant results are returned, including stdout and stderr, and also the command line with which the 'gpg' was called.
The command line with which 'gpg' was called is not always returned as information, and the return code of 'gpg' is not always checked, and the stdout/stderr is not always returned as information.