[2.10] get_url: Fix checksum binary validation #74674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.10
resmo
changed the title
resmo
changed the title
|
The test |
ansibot
added
core_review
samdoran
added
the
ci_verified
|
needs_info (failing CI) |
ansibot
added
the
needs_info
ansibot
added
the
stale_ci
|
@resmo This pullrequest is waiting for your response. Please respond or the pullrequest will be closed. |
ansibot
added
needs_revision
|
rebased |
ansibot
added
core_review
ansibot
added
the
needs_revision
Akasurde
requested changes
Jun 18, 2021
Comment on lines
438
to
447
| - name: download src with sha256 checksum url with file scheme | ||
| get_url: | ||
| url: 'http://localhost:{{ http_port }}/27617.txt' | ||
| dest: '{{ remote_tmp_dir }}/27617sha256_with_file_scheme.txt' | ||
| checksum: 'sha256:file://{{ files_dir }}/sha256sum.txt' | ||
| register: result_sha256_with_file_scheme | ||
|
|
||
| - stat: | ||
| path: "{{ remote_tmp_dir }}/27617sha256_with_dot.txt" | ||
| register: stat_result_sha256_with_file_scheme |
There was a problem hiding this comment.
get_url does not have support for file:// in Stable-2.10 which was added via #71205
Comment on lines
+493
to
+503
| - name: download 71420.txt with sha256 checksum url with file scheme | ||
| get_url: | ||
| url: 'http://localhost:{{ http_port }}/71420.txt' | ||
| dest: '{{ remote_tmp_dir }}/71420sha256_with_file_scheme.txt' | ||
| checksum: 'sha256:file://{{ files_dir }}/sha256sum.txt' | ||
| register: result_sha256_with_file_scheme_71420 | ||
|
|
||
| - stat: | ||
| path: "{{ remote_tmp_dir }}/71420sha256_with_dot.txt" | ||
| register: stat_result_sha256_with_file_scheme_71420 | ||
|
|
samdoran
added
the
ci_verified
ansibot
added
the
stale_ci
|
This needs another rebase and to see if it passes tests now that #75052 was merged. needs_info |
ansibot
added
needs_info
From the sha512sum man page:
... The default mode is to print a line with checksum, a character indicating type ('*' for binary, ' ' for text), and name for each FILE.
(cherry picked from commit 403a5d1)
ansibot
removed
ci_verified
|
rebased but zuul is not happy. I don't see why and how to make zuul happy. |
ansibot
added
core_review
|
The Zuul check was enabled by mistake and can be ignored. |
sivel
removed
the
needs_triage
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
backport of #74502 and #71435 ( /cc @Akasurde )
ISSUE TYPE
COMPONENT NAME
get_url
ADDITIONAL INFORMATION