Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR to fix missing "changed" in net_get to stable-2.9 #74805

Merged
merged 1 commit into from Jun 11, 2021

Conversation

saito-hideki
Copy link
Member

@saito-hideki saito-hideki commented May 24, 2021

SUMMARY

This PR is backporting request to fix net_get module does not initialize changed value. It will avoid to the following problem:

Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/ansible/executor/task_executor.py", line 147, in run
    res = self._execute()
  File "/usr/lib/python2.7/site-packages/ansible/executor/task_executor.py", line 665, in _execute
    result = self._handler.run(task_vars=variables)
  File "/usr/lib/python2.7/site-packages/ansible/plugins/action/net_get.py", line 94, in run
    result['changed'] = changed
UnboundLocalError: local variable 'changed' referenced before assignment
fatal: [192.168.100.100]: FAILED! => {
    "msg": "Unexpected failure during module execution.", 
    "stdout": ""
}
ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • net_get on stable-2.9
ADDITIONAL INFORMATION

N/A

* Fixes ansible#74802

Signed-off-by: Hideki Saito <saito@fgrep.org>
@ansibot ansibot added affects_2.9 This issue/PR affects Ansible v2.9 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. collection Related to Ansible Collections work collection:ansible.netcommon core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. traceback This issue/PR includes a traceback. labels May 24, 2021
@Akasurde
Copy link
Member

@saito-hideki 2.9 is open for critical security fixes only. cc @sivel @relrod

@samdoran
Copy link
Contributor

recheck

@relrod

This comment has been minimized.

@relrod relrod closed this May 24, 2021
@sivel sivel removed the needs_triage Needs a first human triage before being processed. label May 25, 2021
@relrod relrod reopened this Jun 3, 2021
@relrod relrod merged commit c49092f into ansible:stable-2.9 Jun 11, 2021
@ansible ansible locked and limited conversation to collaborators Jul 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.9 This issue/PR affects Ansible v2.9 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. collection:ansible.netcommon collection Related to Ansible Collections work core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. traceback This issue/PR includes a traceback.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants