Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bp-2.11] filters: Add a note about seed #74874

Merged
merged 2 commits into from Jun 3, 2021
Merged

[bp-2.11] filters: Add a note about seed #74874

merged 2 commits into from Jun 3, 2021

Conversation

Akasurde
Copy link
Member

@Akasurde Akasurde commented Jun 1, 2021

SUMMARY

While using seed paramater of random API, behavior
changes between Python 2 and Python 3.
Added a note about this in the documentation.

Fixes: #63784

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

docs/docsite/rst/user_guide/playbooks_filters.rst

@Akasurde
[bp-2.11] filters: Add a note about seed
56c305d 
While using ``seed`` paramater of random API, behavior
changes between Python 2 and Python 3.
Added a note about this in the documentation.

Fixes: ansible#63784

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@Akasurde Akasurde mentioned this pull request Jun 1, 2021
Closed
@Akasurde
Copy link
Member Author

Akasurde commented Jun 1, 2021

Directly opened PR against 2.11, since 2.12 requires Python 3.8.

@ansibot ansibot added affects_2.11 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docs_only All changes are to files within the docs/docsite/ directory needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jun 1, 2021
acozine
acozine reviewed Jun 2, 2021
View reviewed changes
Copy link
Contributor

@acozine acozine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for drafting this @Akasurde! I tried to make the warning more specific to the Python 2 / Python 3 upgrade. If you approve, accept the suggestion and I'll merge.

docs/docsite/rst/user_guide/playbooks_filters.rst Outdated Show resolved Hide resolved
docs/docsite/rst/user_guide/playbooks_filters.rst Outdated Show resolved Hide resolved
docs/docsite/rst/user_guide/playbooks_filters.rst Outdated Show resolved Hide resolved
@samccann samccann removed the needs_triage Needs a first human triage before being processed. label Jun 3, 2021
@samccann @acozine
Apply suggestions from code review
a5c2e99 
Co-authored-by: Alicia Cozine <879121+acozine@users.noreply.github.com>
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 3, 2021
@acozine acozine merged commit 6987150 into ansible:stable-2.11 Jun 3, 2021
@ansible ansible locked and limited conversation to collaborators Jul 1, 2021
@Akasurde Akasurde deleted the bp_2_11_63784 branch August 22, 2023 15:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@acozine acozine acozine left review comments

@samdoran samdoran samdoran approved these changes

@samccann samccann samccann approved these changes

@lmalivert lmalivert Awaiting requested review from lmalivert

Assignees
No one assigned
Labels
affects_2.11 backport This PR does not target the devel branch. bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. docs_only All changes are to files within the docs/docsite/ directory docs This issue/PR relates to or includes documentation. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Akasurde @acozine @samdoran @samccann @ansibot