Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ansible-pull - update help info for --directory option #74936

Merged
merged 2 commits into from Jun 10, 2021
Merged

ansible-pull - update help info for --directory option #74936

merged 2 commits into from Jun 10, 2021

Conversation

Shrews
Copy link
Contributor

@Shrews Shrews commented Jun 8, 2021

SUMMARY

Clarify that only absolute paths are supported for -d or --directory option.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

ansible-pull

@ansibot ansibot added affects_2.12 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jun 8, 2021
@ansibot
Copy link
Contributor

ansibot commented Jun 8, 2021

The test ansible-test sanity --test pep8 [explain] failed with 1 error:

lib/ansible/cli/pull.py:97:161: E501: line too long (170 > 160 characters)

click here for bot help

@ansibot ansibot added ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jun 8, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed ci_verified Changes made in this PR are causing tests to fail. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 8, 2021
@Shrews Shrews mentioned this pull request Jun 9, 2021
Closed
1 task
@jborean93 jborean93 removed the needs_triage Needs a first human triage before being processed. label Jun 10, 2021
@jborean93 jborean93 merged commit 6539c59 into ansible:devel Jun 10, 2021
Shrews added a commit to Shrews/ansible that referenced this pull request Jun 14, 2021
@Shrews
ansible-pull - update help info for --directory option (ansible#74936)
dc4df8a 
* Update -d help info for ansible-pull

* fix pep8

(cherry picked from commit 6539c59)
@Shrews Shrews mentioned this pull request Jun 14, 2021
Merged
@Shrews Shrews deleted the update-pull-docs branch June 14, 2021 13:19
relrod pushed a commit that referenced this pull request Jun 14, 2021
@Shrews
ansible-pull - update help info for --directory option (#74936) (#74993)
a16dd11 
* Update -d help info for ansible-pull

* fix pep8

(cherry picked from commit 6539c59)
@ansible ansible locked and limited conversation to collaborators Jul 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.12 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Shrews @ansibot @jborean93