Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unfrack extra vars #75127

Merged
merged 7 commits into from Jun 30, 2021
Merged

Unfrack extra vars #75127

merged 7 commits into from Jun 30, 2021

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Jun 28, 2021

Since now it is possible to re-reference them mid play, we cannot rely on the initial load having the correct relative path.

fixes #75126

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

args parsing

@ansibot ansibot added affects_2.12 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jun 28, 2021
@ansibot ansibot added support:community This issue/PR relates to code supported by the Ansible community. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jun 28, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 28, 2021
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jun 29, 2021
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. labels Jun 29, 2021
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Jun 29, 2021
@bcoca @Akasurde
Update lib/ansible/cli/arguments/option_helpers.py
9b80d01 
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot ansibot added the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. label Jun 29, 2021
tadeboro
tadeboro approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@tadeboro tadeboro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @bcoca, for taking care of this.

@ansibot ansibot removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jun 29, 2021
@ansibot ansibot added the core_review In order to be merged, this PR must follow the core review workflow. label Jun 29, 2021
@bcoca bcoca merged commit 60c9f04 into ansible:devel Jun 30, 2021
@bcoca bcoca deleted the unfrack_extra_vars branch June 30, 2021 13:39
bcoca added a commit to bcoca/ansible that referenced this pull request Jun 30, 2021
@bcoca
Unfrack extra vars (ansible#75127)
479fcde 
* Ensure we keep teh original path as per cli

  fixes ansible#75126

Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 60c9f04)
relrod pushed a commit that referenced this pull request Jul 12, 2021
@bcoca
Unfrack extra vars (#75127) (#75148)
3b5bc9b 
* Ensure we keep the original path as per cli

  fixes #75126

Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
(cherry picked from commit 60c9f04)
@ansible ansible locked and limited conversation to collaborators Jul 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Akasurde Akasurde Akasurde left review comments

@tadeboro tadeboro tadeboro approved these changes

Assignees
No one assigned
Labels
affects_2.12 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ansible fails to load extra variable file on inventory reload
4 participants
@bcoca @tadeboro @Akasurde @ansibot