Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate scp_if_ssh #75218

Merged
merged 5 commits into from Nov 1, 2021
Merged

deprecate scp_if_ssh #75218

merged 5 commits into from Nov 1, 2021

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Jul 8, 2021

ssh_transfer_method has overridden this for a long time already

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

connection/ssh

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.12 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jul 8, 2021
@bcoca @sivel
Update lib/ansible/plugins/connection/ssh.py
f4eb8c1 
Co-authored-by: Matt Martz <matt@sivel.net>
@bcoca
Copy link
Member Author

bcoca commented Jul 8, 2021

then i'll split this, put this PR in for 2.13 and create docs pr with just the note about the override

@bcoca bcoca added this to the 2.12 milestone Jul 8, 2021
@ansibot ansibot added the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. label Jul 8, 2021
@bcoca bcoca modified the milestones: 2.12, 2.13 Jul 8, 2021
@ansibot ansibot removed the needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. label Jul 8, 2021
@ansibot

This comment has been minimized.

Sign in to view
@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Jul 13, 2021
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 21, 2021
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. and removed stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. labels Aug 30, 2021
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 8, 2021
@bcoca bcoca marked this pull request as ready for review September 17, 2021 14:21
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. labels Sep 17, 2021
@bcoca
Copy link
Member Author

bcoca commented Nov 1, 2021

/azp run

@ansible ansible deleted a comment from azure-pipelines bot Nov 1, 2021
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ansibot ansibot removed the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Nov 1, 2021
@bcoca bcoca merged commit d23226a into ansible:devel Nov 1, 2021
@bcoca bcoca deleted the ssh_options_redux branch November 1, 2021 14:49
@ansible ansible locked and limited conversation to collaborators Nov 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sivel sivel sivel approved these changes

Assignees
No one assigned
Labels
affects_2.12 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
2.13
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bcoca @ansibot @sivel