Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s: Migrated scenario guides to collection #75249

Merged
merged 1 commit into from Dec 17, 2021

Conversation

Akasurde
Copy link
Member

SUMMARY

Kubernetes scenario guides are moved to
kubernetes.core collection.

Signed-off-by: Abhijeet Kasurde akasurde@redhat.com

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

changelogs/fragments/migrated_k8s_scenario_guides.yml
docs/docsite/rst/community/contributing_maintained_collections.rst
docs/docsite/rst/scenario_guides/guide_kubernetes.rst
docs/docsite/rst/scenario_guides/guides.rst
docs/docsite/rst/scenario_guides/kubernetes_scenarios/k8s_intro.rst
docs/docsite/rst/scenario_guides/kubernetes_scenarios/k8s_inventory.rst
docs/docsite/rst/scenario_guides/kubernetes_scenarios/k8s_scenarios.rst
docs/docsite/rst/scenario_guides/kubernetes_scenarios/scenario_k8s_object.rst
docs/docsite/rst/scenario_guides/kubernetes_scenarios/task_outputs/Add_a_pod_using_k8s.json
docs/docsite/rst/scenario_guides/kubernetes_scenarios/task_outputs/Add_a_pod_using_k8s.yaml
docs/docsite/rst/scenario_guides/virt_guides.rst

Kubernetes scenario guides are moved to
``kubernetes.core`` collection.

Signed-off-by: Abhijeet Kasurde <akasurde@redhat.com>
@ansibot ansibot added affects_2.12 docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. core_review In order to be merged, this PR must follow the core review workflow. and removed needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jul 14, 2021
@Akasurde Akasurde added docs_only All changes are to files within the docs/docsite/ directory and removed needs_triage Needs a first human triage before being processed. labels Jul 14, 2021
@ansibot ansibot removed the docs_only All changes are to files within the docs/docsite/ directory label Jul 14, 2021
@samccann
Copy link
Contributor

Thanks for moving these @Akasurde! We can't merge this PR until the guides show up on docs.ansible.com again. That means:

  1. kubernetes.core has a release up on galaxy that includes the moved guides
  2. Ansible package release picks up the new set of guides from galaxy and displays them in the kuberneetes.core collection list on docs.ansible.com.

Since Ansible releases every 3 weeks or so, we'll have to wait on merging until then to pick up step 2 above, so I'll put this in draft mode in github until then...

@samccann samccann marked this pull request as draft July 15, 2021 14:58
@@ -193,7 +193,7 @@ The following table shows:
<td>✓</td>
<td>GitHub Actions</td>
<td>✓</td>
<td><a href="https://docs.ansible.com/ansible/devel/scenario_guides/guide_kubernetes.html">Kubernetes guide</a></td>
<td></td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of removing the old link, can you put in a new link to the new location (once it's available.. which is after a new kubernetes release on galaxy has the guides, and after Ansible the package releases to capture that new version of kubernetes..). Same for the other link removal.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it.

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. and removed core_review In order to be merged, this PR must follow the core review workflow. labels Jul 15, 2021
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Jul 28, 2021
@samccann samccann marked this pull request as ready for review December 14, 2021 21:41
@samccann
Copy link
Contributor

Kubernetes guides are now up on docs.ansible.com from within the collections so we can merge this PR.

@samccann
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ansibot ansibot removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Dec 14, 2021
@ansibot ansibot added the core_review In order to be merged, this PR must follow the core review workflow. label Dec 14, 2021
@samccann samccann merged commit 601d66c into ansible:devel Dec 17, 2021
@Akasurde Akasurde deleted the remove_k8s_docs branch December 20, 2021 06:39
@ansible ansible locked and limited conversation to collaborators Dec 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.12 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docsite This issue/PR relates to the documentation website. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants