Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix indents for 2nd example #75489

Merged
merged 2 commits into from
Feb 10, 2022
Merged

Fix indents for 2nd example #75489

merged 2 commits into from
Feb 10, 2022

Conversation

zasca
Copy link

@zasca zasca commented Aug 12, 2021

SUMMARY
ISSUE TYPE
  • Docs Pull Request

+label: docsite_pr

SUMMARY
ISSUE TYPE
  • Bugfix Pull Request
  • Docs Pull Request
  • Feature Pull Request
  • Test Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

@zasca
Fix indents for the 2nd example
6b1a39b 
##### SUMMARY
<!--- Your description here -->


##### ISSUE TYPE
- Docs Pull Request

+label: docsite_pr
@zasca zasca changed the title Fix indents for the 2nd example Fix indents for 2nd example Aug 12, 2021
@ansibot ansibot added affects_2.12 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docs_only All changes are to files within the docs/docsite/ directory needs_triage Needs a first human triage before being processed. new_contributor This PR is the first contribution by a new community member. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Aug 12, 2021
@nitzmahone
Copy link
Member

Both indentation styles are valid, and this change makes the file internally inconsistent with the other indentation above. The addition of tasks is good, but we'll probably pass on the indentation change.

@nitzmahone nitzmahone removed the needs_triage Needs a first human triage before being processed. label Aug 12, 2021
samccann
samccann previously approved these changes Aug 18, 2021
View reviewed changes
@samccann samccann dismissed their stale review August 18, 2021 20:44

rereading comments

@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Aug 26, 2021
samccann
samccann reviewed Feb 10, 2022
View reviewed changes
Copy link
Contributor

@samccann samccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

attempting to remove the uneccessary indenting.

docs/docsite/rst/user_guide/playbooks_handlers.rst Outdated Show resolved Hide resolved
docs/docsite/rst/user_guide/playbooks_handlers.rst Outdated Show resolved Hide resolved
docs/docsite/rst/user_guide/playbooks_handlers.rst Outdated Show resolved Hide resolved
docs/docsite/rst/user_guide/playbooks_handlers.rst Outdated Show resolved Hide resolved
docs/docsite/rst/user_guide/playbooks_handlers.rst Outdated Show resolved Hide resolved
docs/docsite/rst/user_guide/playbooks_handlers.rst Outdated Show resolved Hide resolved
docs/docsite/rst/user_guide/playbooks_handlers.rst Outdated Show resolved Hide resolved
docs/docsite/rst/user_guide/playbooks_handlers.rst Outdated Show resolved Hide resolved
docs/docsite/rst/user_guide/playbooks_handlers.rst Outdated Show resolved Hide resolved
@samccann samccann merged commit 8939f4d into ansible:devel Feb 10, 2022
@samccann
Copy link
Contributor

Thanks @zasca for the Ansible docs fix! We talk about Ansible documentation on maxtrix at #docs:ansible.im and on libera IRC at #ansible-docs if you ever want to join us and chat about the docs!

@ansible ansible locked and limited conversation to collaborators Feb 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samccann samccann samccann approved these changes

Assignees
No one assigned
Labels
affects_2.12 core_review In order to be merged, this PR must follow the core review workflow. docs_only All changes are to files within the docs/docsite/ directory docs This issue/PR relates to or includes documentation. new_contributor This PR is the first contribution by a new community member. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zasca @nitzmahone @samccann @ansibot