Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exhaust list of vault ids before failing #75540

Merged
merged 4 commits into from Nov 1, 2021
Merged

exhaust list of vault ids before failing #75540

merged 4 commits into from Nov 1, 2021

Conversation

s-hertel
Copy link
Contributor

SUMMARY

If a configured vault secret isn't accessible, don't fail until it's used (or if no valid vault secrets are found).

Fixes #58938

ISSUE TYPE
  • Bugfix Pull Request

@ansibot ansibot added WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. affects_2.12 bug This issue/PR relates to a bug. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Aug 20, 2021
@s-hertel s-hertel mentioned this pull request Aug 20, 2021
Closed
@ansibot ansibot added the support:community This issue/PR relates to code supported by the Ansible community. label Aug 23, 2021
@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added the ci_verified Changes made in this PR are causing tests to fail. label Aug 23, 2021
@s-hertel s-hertel removed the needs_triage Needs a first human triage before being processed. label Aug 24, 2021
@s-hertel s-hertel changed the title [WIP] exhaust list of vault ids before failing exhaust list of vault ids before failing Aug 25, 2021
@s-hertel s-hertel requested a review from bcoca August 25, 2021 19:33
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed WIP This issue/PR is a work in progress. Nevertheless it was shared for getting input from peers. ci_verified Changes made in this PR are causing tests to fail. core_review In order to be merged, this PR must follow the core review workflow. labels Aug 25, 2021
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 8, 2021
@ansibot ansibot removed needs_rebase https://docs.ansible.com/ansible/devel/dev_guide/developing_rebasing.html needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. labels Sep 21, 2021
@ansibot ansibot added the core_review In order to be merged, this PR must follow the core review workflow. label Sep 21, 2021
@ansibot ansibot added the stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. label Sep 30, 2021
@bcoca bcoca merged commit 8bbecc7 into ansible:devel Nov 1, 2021
@ansible ansible locked and limited conversation to collaborators Nov 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bcoca bcoca bcoca approved these changes

Assignees
No one assigned
Labels
affects_2.12 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. has_issue stale_ci This PR has been tested by CI more than one week ago. Close and re-open this PR to get it retested. support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ignore missing/failed vault ids in vault_identity_list
3 participants
@s-hertel @ansibot @bcoca