Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate-modules: fix choices for return values #76070

Merged
merged 1 commit into from Oct 19, 2021

Conversation

felixfontein
Copy link
Contributor

SUMMARY

In #76009 it looks like I only added choices for subvalues of return values, not for top-level return values themselves.

This fixes #76009 to also work for top-level return values.

(I didn't include a changelog fragment since #76009 isn't part of a release yet.)

ISSUE TYPE
  • Bugfix Pull Request
  • Feature Pull Request
COMPONENT NAME

validate-modules

@ansibot ansibot added affects_2.13 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests. labels Oct 18, 2021
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Oct 19, 2021
@mkrizek mkrizek merged commit 227f439 into ansible:devel Oct 19, 2021
@felixfontein felixfontein deleted the return-choices-2 branch October 19, 2021 15:39
@felixfontein
Copy link
Contributor Author

@mkrizek thanks for reviewing and merging!

@ansible ansible locked and limited conversation to collaborators Nov 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
affects_2.13 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team. test This PR relates to tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants