Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs for installing from a git repo #76350

Merged
merged 2 commits into from Dec 14, 2021
Merged

Fix docs for installing from a git repo #76350

merged 2 commits into from Dec 14, 2021

Conversation

s-hertel
Copy link
Contributor

SUMMARY

The documentation implies that the git+ prefix prevents SSH authentication. It doesn't have any effect on that. Also make the docs more generic since git@ is a feature specific to github, gitlab, etc.

ISSUE TYPE
  • Docs Pull Request

@s-hertel s-hertel mentioned this pull request Nov 23, 2021
Closed
1 task
@ansibot ansibot added affects_2.13 core_review In order to be merged, this PR must follow the core review workflow. docs This issue/PR relates to or includes documentation. docs_only All changes are to files within the docs/docsite/ directory has_issue needs_triage Needs a first human triage before being processed. small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Nov 23, 2021
@s-hertel s-hertel force-pushed the fix_installing_collections_git_repo branch from bfb0c92 to b8d10f3 Compare November 23, 2021 16:20
@mkrizek mkrizek removed the needs_triage Needs a first human triage before being processed. label Nov 30, 2021
@ansibot ansibot added needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. core_review In order to be merged, this PR must follow the core review workflow. and removed core_review In order to be merged, this PR must follow the core review workflow. needs_ci This PR requires CI testing to be performed. Please close and re-open this PR to trigger CI. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Nov 30, 2021
@mattclay
Copy link
Member

mattclay commented Dec 2, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@samccann samccann merged commit 146a4bc into ansible:devel Dec 14, 2021
bcoca pushed a commit to bcoca/ansible that referenced this pull request Dec 15, 2021
@s-hertel @bcoca
Fix docs for installing from a git repo (ansible#76350)
6813c21
@ansible ansible locked and limited conversation to collaborators Dec 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samccann samccann samccann approved these changes

Assignees
No one assigned
Labels
affects_2.13 core_review In order to be merged, this PR must follow the core review workflow. docs_only All changes are to files within the docs/docsite/ directory docs This issue/PR relates to or includes documentation. has_issue small_patch support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@s-hertel @mattclay @samccann @mkrizek @ansibot