DNF module upgrades modules with `state: present` or `state: installed` #76384

1kaw · 2021-11-29T14:23:58Z

Summary

When running the DNF module with state: present or state: installed, certain packages will be upgraded even though they should be skipped with that parameter.

Issue Type

Bug Report

Component Name

dnf

Ansible Version

$ ansible --version
ansible 2.10.15
  config file = None
  configured module search path = ['/root/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/local/lib/python3.6/site-packages/ansible
  executable location = /usr/local/bin/ansible
  python version = 3.6.8 (default, Aug 24 2020, 17:57:11) [GCC 8.3.1 20191121 (Red Hat 8.3.1-5)]

Configuration

$ ansible-config dump --only-changed

OS / Environment

CentOS 8

Steps to Reproduce

redis package is already installed.

[root@c8 ~]# rpm -qa | grep redis
redis-5.0.3-2.module_el8.2.0+318+3d7e67ea.x86_64

Next, run the following playbook.

- hosts: localhost
  tasks:
    - dnf:
        name: '@redis:5'
        state: present

Expected Results

With state: present or installed, it is expected that packages with available updates do not get updated.

Actual Results

TASK [dnf] *************************************************************************************************************************************************
task path: /root/playbook.yml:3
<127.0.0.1> ESTABLISH LOCAL CONNECTION FOR USER: root
<127.0.0.1> EXEC /bin/sh -c 'echo ~root && sleep 0'
<127.0.0.1> EXEC /bin/sh -c '( umask 77 && mkdir -p "` echo /root/.ansible/tmp `"&& mkdir "` echo /root/.ansible/tmp/ansible-tmp-1638195909.4688942-5425-281163792679993 `" && echo ansible-tmp-1638195909.4688942-5425-281163792679993="` echo /root/.ansible/tmp/ansible-tmp-1638195909.4688942-5425-281163792679993 `" ) && sleep 0'
Using module file /usr/local/lib/python3.6/site-packages/ansible/modules/dnf.py
<127.0.0.1> PUT /root/.ansible/tmp/ansible-local-53303e4t90od/tmpmpdxsfb2 TO /root/.ansible/tmp/ansible-tmp-1638195909.4688942-5425-281163792679993/AnsiballZ_dnf.py
<127.0.0.1> EXEC /bin/sh -c 'chmod u+x /root/.ansible/tmp/ansible-tmp-1638195909.4688942-5425-281163792679993/ /root/.ansible/tmp/ansible-tmp-1638195909.4688942-5425-281163792679993/AnsiballZ_dnf.py && sleep 0'
<127.0.0.1> EXEC /bin/sh -c '/usr/bin/python3.6 /root/.ansible/tmp/ansible-tmp-1638195909.4688942-5425-281163792679993/AnsiballZ_dnf.py && sleep 0'
<127.0.0.1> EXEC /bin/sh -c 'rm -f -r /root/.ansible/tmp/ansible-tmp-1638195909.4688942-5425-281163792679993/ > /dev/null 2>&1 && sleep 0'
changed: [localhost] => {
    "changed": true,
    "invocation": {
        "module_args": {
            "allow_downgrade": false,
            "allowerasing": false,
            "autoremove": false,
            "bugfix": false,
            "conf_file": null,
            "disable_excludes": null,
            "disable_gpg_check": false,
            "disable_plugin": [],
            "disablerepo": [],
            "download_dir": null,
            "download_only": false,
            "enable_plugin": [],
            "enablerepo": [],
            "exclude": [],
            "install_repoquery": true,
            "install_weak_deps": true,
            "installroot": "/",
            "list": null,
            "lock_timeout": 30,
            "name": [
                "@redis:5"
            ],
            "releasever": null,
            "security": false,
            "skip_broken": false,
            "state": "present",
            "update_cache": false,
            "update_only": false,
            "validate_certs": true
        }
    },
    "msg": "Check mode: No changes made, but would have if not in check mode",
    "rc": 0,
    "results": [
        "Installed: redis-5.0.3-5.module_el8.4.0+955+7126e393.x86_64",
        "Removed: redis-5.0.3-2.module_el8.2.0+318+3d7e67ea.x86_64"
    ]
}
META: ran handlers
META: ran handlers

Code of Conduct

I agree to follow the Ansible Code of Conduct

The text was updated successfully, but these errors were encountered:

ansibot · 2021-11-29T14:25:09Z

Files identified in the description:

lib/ansible/modules/dnf.py

If these files are incorrect, please update the component name section of the description or use the !component bot command.

click here for bot help

1kaw · 2021-11-29T14:35:49Z

related #75311

sivel · 2021-11-29T21:57:45Z

I guess maybe the 2 lines to install and enable the module are not indented far enough?

ansible/lib/ansible/modules/dnf.py

Lines 1056 to 1059 in c56d98e

    
           if not self._is_module_installed(module): 
        
               response['results'].append("Module {0} installed.".format(module)) 
        
           self.module_base.install([module]) 
        
           self.module_base.enable([module])

1kaw · 2021-12-02T01:19:00Z

AppStream does not retain old versions.

So, I think we need to prepare a repository (including modules) for testing to prevent degressive behavior in the future.

1kaw · 2021-12-07T23:34:21Z

It also occurs when not in check mode

jameslivulpi · 2021-12-08T13:25:29Z

See 76467 for some details particularly my last comment which is related.

The issue here with installing module seems to be that dnf doesn't honor the best option in dnf.conf when using dnf module install .. or dnf install @<package> From dnf docs I can't see anything mentioning its not supported for these 2 cases.

e.g.,:

This looks good:

[root@centos-s-1vcpu-1gb-nyc1-01 ~]# dnf install redis --nobest
Last metadata expiration check: 0:04:07 ago on Wed 08 Dec 2021 01:17:21 PM UTC.
Package redis-5.0.3-2.module_el8.2.0+318+3d7e67ea.x86_64 is already installed.
Dependencies resolved.
Nothing to do.
Complete!

This doesn't look correct, I would expect it to show like the above " is already installed."

[root@centos-s-1vcpu-1gb-nyc1-01 ~]# dnf install @redis  --nobest
Last metadata expiration check: 0:00:06 ago on Wed 08 Dec 2021 01:22:26 PM UTC.
Dependencies resolved.
==========================================================================================================================================================================
 Package                         Architecture                     Version                                                       Repository                           Size
==========================================================================================================================================================================
Upgrading:
 redis                           x86_64                           5.0.3-5.module_el8.4.0+955+7126e393                           appstream                           927 k

Transaction Summary
==========================================================================================================================================================================
Upgrade  1 Package

Total size: 927 k
Is this ok [y/N]:

maxamillion · 2022-02-27T03:16:29Z

See 76467 for some details particularly my last comment which is related.

The issue here with installing module seems to be that dnf doesn't honor the best option in dnf.conf when using dnf module install .. or dnf install @<package> From dnf docs I can't see anything mentioning its not supported for these 2 cases.

e.g.,:

This looks good:

[root@centos-s-1vcpu-1gb-nyc1-01 ~]# dnf install redis --nobest
Last metadata expiration check: 0:04:07 ago on Wed 08 Dec 2021 01:17:21 PM UTC.
Package redis-5.0.3-2.module_el8.2.0+318+3d7e67ea.x86_64 is already installed.
Dependencies resolved.
Nothing to do.
Complete!

This doesn't look correct, I would expect it to show like the above " is already installed."

[root@centos-s-1vcpu-1gb-nyc1-01 ~]# dnf install @redis  --nobest
Last metadata expiration check: 0:00:06 ago on Wed 08 Dec 2021 01:22:26 PM UTC.
Dependencies resolved.
==========================================================================================================================================================================
 Package                         Architecture                     Version                                                       Repository                           Size
==========================================================================================================================================================================
Upgrading:
 redis                           x86_64                           5.0.3-5.module_el8.4.0+955+7126e393                           appstream                           927 k

Transaction Summary
==========================================================================================================================================================================
Upgrade  1 Package

Total size: 927 k
Is this ok [y/N]:

this gets even more fun because the Ansible dnf module doesn't call the cli, but uses the python library which appears to mimic the behavior which leads me to think this is an upstream DNF bug

Alex-ala · 2022-12-01T13:04:10Z

This issue still persists with Ansible 2.14.0 and dnf 4.7.0* or 4.4.2* on CentOS 8 Stream.
I could not find a dnf version, where this is properly working.

Are there any updates on this topic or the PR provided in above comments? (#76467)

dlakatos847 · 2024-01-19T12:46:42Z

Still an issue with Ansible 2.16.2 running on RHEL 8.6.

1kaw changed the title ~~DNF module upgrades packages with state: present or state: installed~~ DNF module upgrades packages with state: present or state: installed Dec 1, 2021

nitzmahone removed the needs_triage Needs a first human triage before being processed. label Dec 2, 2021

1kaw mentioned this issue Dec 4, 2021

DNF module upgrades packages with state: present or state: installed #76463

Closed

1 task

mkrizek changed the title ~~DNF module upgrades packages with state: present or state: installed~~ DNF module upgrades modules with state: present or state: installed Dec 7, 2021

s-hertel added the P3 Priority 3 - Approved, No Time Limitation label Aug 3, 2022

isuftin mentioned this issue Jul 21, 2023

package module upgrades modules with state: present #81325

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DNF module upgrades modules with `state: present` or `state: installed` #76384

DNF module upgrades modules with `state: present` or `state: installed` #76384

1kaw commented Nov 29, 2021 •

edited

ansibot commented Nov 29, 2021

1kaw commented Nov 29, 2021

sivel commented Nov 29, 2021

1kaw commented Dec 2, 2021

1kaw commented Dec 7, 2021

jameslivulpi commented Dec 8, 2021

maxamillion commented Feb 27, 2022

Alex-ala commented Dec 1, 2022

dlakatos847 commented Jan 19, 2024

DNF module upgrades modules with state: present or state: installed #76384

DNF module upgrades modules with state: present or state: installed #76384

Comments

1kaw commented Nov 29, 2021 • edited

Summary

Issue Type

Component Name

Ansible Version

Configuration

OS / Environment

Steps to Reproduce

Expected Results

Actual Results

Code of Conduct

ansibot commented Nov 29, 2021

1kaw commented Nov 29, 2021

sivel commented Nov 29, 2021

1kaw commented Dec 2, 2021

1kaw commented Dec 7, 2021

jameslivulpi commented Dec 8, 2021

maxamillion commented Feb 27, 2022

Alex-ala commented Dec 1, 2022

dlakatos847 commented Jan 19, 2024

DNF module upgrades modules with `state: present` or `state: installed` #76384

DNF module upgrades modules with `state: present` or `state: installed` #76384

1kaw commented Nov 29, 2021 •

edited