pkg_mgr: prohibit pkg5 usage on Altlinux

[ptrnine]

SUMMARY

The current implementation expects /usr/bin/pkg as pkg5 package manager, but this is not suitable for Altlinux. There is an perl-Package rpm package that has an executable with the same path as pkg5 (/usr/bin/pkg).
Since the pkg5 takes precedence over apt, this patch is required to select an appropriate package manager on Altlinux.

ISSUE TYPE

• Bugfix Pull Request

COMPONENT NAME

pkg_mgr

[mkrizek]

This would need a changelog, see https://docs.ansible.com/ansible/devel/community/development_process.html#changelogs-how-to.

[bcoca]

this is incorrect, apt-get has higher precedence than pkg

[ptrnine]

It's correct:

ansible/lib/ansible/module_utils/facts/system/pkg_mgr.py

Lines 13 to 15 in 7830e53

	# A list of dicts. If there is a platform with more than one
	# package manager, put the preferred one last. If there is an
	# ansible module, use that as the value for the 'name' key.

Each next pkg['name'] in PKG_MGRS can rewrite the pkg_mgr_name:

ansible/lib/ansible/module_utils/facts/system/pkg_mgr.py

Lines 121 to 123 in 7830e53

	for pkg in PKG_MGRS:
	if os.path.exists(pkg['path']):
	pkg_mgr_name = pkg['name']

And so pkg5 takes precedence over apt.

[bcoca]

You are correct, I didn't look at all the code and assumed assumed there was a break on match, its last, not first, found wins ... which makes me want to rewrite this section.

Not only can we have multiple package managers (add fact with list), but the traversal can be reversed + break to make it perform better. Another 'optimization' would be to create diff lists for OS families.

[bcoca]

merged this to fix this specific problem, but making note on needing to rethink pkg manager detection.