New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tencentos fact distro #76459
Merged
Merged
add tencentos fact distro #76459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.13
bug
This issue/PR relates to a bug.
core_review
In order to be merged, this PR must follow the core review workflow.
needs_triage
Needs a first human triage before being processed.
new_contributor
This PR is the first contribution by a new community member.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
labels
Dec 3, 2021
Akasurde
requested changes
Dec 6, 2021
ansibot
added
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
and removed
core_review
In order to be merged, this PR must follow the core review workflow.
labels
Dec 6, 2021
Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
ansibot
added
core_review
In order to be merged, this PR must follow the core review workflow.
and removed
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
labels
Dec 6, 2021
ansibot
added
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
and removed
core_review
In order to be merged, this PR must follow the core review workflow.
labels
Dec 6, 2021
Akasurde
reviewed
Dec 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, waiting for others to comment.
mkrizek
approved these changes
Dec 7, 2021
mkrizek
removed
the
needs_triage
Needs a first human triage before being processed.
label
Dec 7, 2021
bcoca
pushed a commit
to bcoca/ansible
that referenced
this pull request
Dec 15, 2021
Fixes ansible#76459 Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
konstruktoid
pushed a commit
to konstruktoid/ansible-upstream
that referenced
this pull request
Feb 2, 2022
Fixes ansible#76459 Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
bcoca
pushed a commit
to bcoca/ansible
that referenced
this pull request
Feb 7, 2022
Fixes ansible#76459 Co-authored-by: Abhijeet Kasurde <akasurde@redhat.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
affects_2.13
bug
This issue/PR relates to a bug.
needs_revision
This PR fails CI tests or a maintainer has requested a review/revision of the PR.
new_contributor
This PR is the first contribution by a new community member.
support:core
This issue/PR relates to code supported by the Ansible Engineering Team.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
takes care of #76343
Correct the distribution fact if node is running TencentOS
ISSUE TYPE
COMPONENT NAME
distribution
fact getheringADDITIONAL INFORMATION
Before this fix:
test.yml:
Failed with:
After fix:
installs via dnf and succeeds: