Adding modularity tag to task modularity.yml

[martinobanana]

SUMMARY

Add tag to modularity dnf test to be able to disable it through --skip-tags option

ISSUE TYPE

• Test Pull Request

COMPONENT NAME

dnf integration tests

ADDITIONAL INFORMATION

Some distributions can be shipped without modules and user then should be able to skip modularity testing, e.g. using --skip-tags option.

[jborean93]

What are you trying to achieve with this PR, I don't believe ansible-test allows you to pass through tags so having this in the integration tests doesn't make sense.

needs_info

[martinobanana]

It somehow works for me, the task "TASK [dnf : install "@container-tools:latest/common" module]" is skipped:

[root@ci-vm-10-0-139-49 ansible]# ansible-test integration yum dnf --requirements -v --allow-destructive | grep TASK > log_with_modules
Execute command: /usr/bin/python /tmp/ansible-test-cfzl45fk-pip.py install --disable-pip-version-check -r requirements/ansible.txt -c requirements/constraints.txt
NOTICE: To resume at this test target, use the option: --start-at dnf
NOTICE: To resume after this test target, use the option: --start-at yum
ERROR: Command "ansible-playbook dnf-p41kyp0g.yml -i inventory -v" returned exit status 2.
[root@ci-vm-10-0-139-49 ansible]# ansible-test integration yum dnf --requirements -v --allow-destructive --skip-tags modularity | grep TASK > log_without_modules
Execute command: /usr/bin/python /tmp/ansible-test-gigpvpoh-pip.py install --disable-pip-version-check -r requirements/ansible.txt -c requirements/constraints.txt
NOTICE: To resume at this test target, use the option: --start-at dnf
NOTICE: To resume after this test target, use the option: --start-at yum
ERROR: Command "ansible-playbook dnf-d2n8prvg.yml -i inventory --skip-tags modularity -v" returned exit status 2.

[root@ci-vm-10-0-139-49 ansible]# tail -n6 log_with_modules ; echo; tail -n15 log_without_modules
TASK [dnf : verify dnf module outputs in /] ************************************
TASK [dnf : cleanup installroot] ***********************************************
TASK [dnf : include_tasks] *****************************************************
TASK [dnf : include_tasks] *****************************************************
TASK [dnf : Include distribution specific variables] ***************************
TASK [dnf : install "@container-tools:latest/common" module] *******************

TASK [dnf : verify dnf module outputs in /] ************************************
TASK [dnf : cleanup installroot] ***********************************************
TASK [dnf : include_tasks] *****************************************************
TASK [dnf : include_tasks] *****************************************************
TASK [dnf : Install latest version python3-dnf] ********************************
TASK [dnf : Verify python3-dnf installed] **************************************
TASK [dnf : Get python3-dnf version] *******************************************
TASK [dnf : remove logfiles if exist] ******************************************
TASK [dnf : Install sos package] ***********************************************
TASK [dnf : Get status of logfiles] ********************************************
TASK [dnf : Verify logfile exists] *********************************************
TASK [dnf : include_tasks] *****************************************************
TASK [dnf : include_tasks] *****************************************************
TASK [dnf : Test cacheonly (clean before testing)] *****************************
TASK [dnf : Try installing from cache where it has been cleaned] ***************

[root@ci-vm-10-0-139-49 ansible]# grep container-tools log_with*
log_with_modules:TASK [dnf : install "@container-tools:latest/common" module] *******************
[root@ci-vm-10-0-139-49 ansible]# wc -l log_with*
304 log_with_modules
313 log_without_modules

[bcoca]

it is a rarely used feature, but it does work.

My only point is that the tag is too generic, dnf_modularity would be my preference