Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssh connection avoid parsiing own debug #76732

Merged
merged 4 commits into from Jan 13, 2022
Merged

ssh connection avoid parsiing own debug #76732

merged 4 commits into from Jan 13, 2022

Conversation

bcoca
Copy link
Member

@bcoca bcoca commented Jan 11, 2022 •
edited

skip lines that start with debug[0-9]:
fixes #76663
fixes #74417
fixes #75834

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

connection/ssh

@ansibot

This comment has been minimized.

Sign in to view
@ansibot ansibot added affects_2.13 bug This issue/PR relates to a bug. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. needs_triage Needs a first human triage before being processed. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels Jan 11, 2022
@ansibot ansibot added core_review In order to be merged, this PR must follow the core review workflow. and removed needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. labels Jan 12, 2022
@sivel
Copy link
Member

sivel commented Jan 13, 2022

As an FYI, I've tested this, and this does seem to resolve the issue that I can reproduce.

@bcoca bcoca removed the needs_triage Needs a first human triage before being processed. label Jan 13, 2022
@bcoca
added test for debug lines
9eba247 
  also simplified some of existing test code
@bcoca bcoca merged commit 0ff80a1 into ansible:devel Jan 13, 2022
@bcoca bcoca deleted the ssh_dont_parse_debug branch January 13, 2022 21:28
bcoca added a commit to bcoca/ansible that referenced this pull request Jan 13, 2022
@bcoca
ssh connection avoid parsiing own debug (ansible#76732)
395732d 
  - Avoids false positives on become strings being echoed back
   by ssh cli itself
  - added test for debug lines
  - also simplified some of existing test code

(cherry picked from commit 0ff80a1)
bcoca added a commit to bcoca/ansible that referenced this pull request Jan 13, 2022
@bcoca
ssh connection avoid parsiing own debug (ansible#76732)
627c9cd 
  - Avoids false positives on become strings being echoed back
   by ssh cli itself
  - added test for debug lines
  - also simplified some of existing test code

(cherry picked from commit 0ff80a1)
@sugitk
Copy link
Contributor

sugitk commented Jan 17, 2022

@bcoca Thank you very much! I applied the PR on my side and I found it worked as expected.
Can we have a plan to backport it to the -stable versions?

@bcoca
Copy link
Member Author

bcoca commented Jan 17, 2022

already did, see #76756 and #76755

nitzmahone pushed a commit that referenced this pull request Jan 19, 2022
@bcoca
ssh connection avoid parsiing own debug (#76732) (#76755)
a60b79d 
- Avoids false positives on become strings being echoed back
   by ssh cli itself
  - added test for debug lines
  - also simplified some of existing test code

(cherry picked from commit 0ff80a1)
nitzmahone pushed a commit that referenced this pull request Jan 19, 2022
@bcoca
ssh connection avoid parsing own debug (#76732) (#76756)
4eac144 
* ssh connection avoid parsiing own debug (#76732)

  - Avoids false positives on become strings being echoed back
   by ssh cli itself
  - added test for debug lines
  - also simplified some of existing test code

(cherry picked from commit 0ff80a1)

* unicoode

* dont make em ascii
@ansible ansible locked and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
affects_2.13 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
4 participants
@bcoca @ansibot @sivel @sugitk