SID - Use literal UPN value when attempting a user to SID lookup #77334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
ansibot
added
affects_2.13
bug
nitzmahone
approved these changes
Mar 24, 2022
bcoca
removed
the
needs_triage
jborean93
added a commit
to jborean93/ansible
that referenced
this pull request
Mar 24, 2022
…ible#77334) (cherry picked from commit ff184b0)
jborean93
added a commit
to jborean93/ansible
that referenced
this pull request
Mar 24, 2022
…ible#77334) (cherry picked from commit ff184b0)
This was referenced Mar 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The code incorrectly splits the UPN into
usernameanddomainfields which does not work well when theusernameexceeds thesAMAccountNamelimits of 20 chars. By using the username as the full UPN Windows will lookup the SID value correctly.Fixes #77316
ISSUE TYPE
COMPONENT NAME
Ansible.ModuleUtils.SID