winrm - ensure callers PATH for kinit is set #77401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansibot
added
affects_2.14
bug
nitzmahone
approved these changes
Mar 29, 2022
nitzmahone
approved these changes
Mar 30, 2022
jborean93
added a commit
to jborean93/ansible
that referenced
this pull request
Mar 30, 2022
* winrm - ensure callers PATH for kinit is set * Fix unit test expectations * Fix type annotation (cherry picked from commit 60b4200)
jborean93
added a commit
to jborean93/ansible
that referenced
this pull request
Mar 30, 2022
* winrm - ensure callers PATH for kinit is set * Fix unit test expectations * Fix type annotation (cherry picked from commit 60b4200)
jborean93
added a commit
to jborean93/ansible
that referenced
this pull request
Mar 30, 2022
* winrm - ensure callers PATH for kinit is set * Fix unit test expectations * Fix type annotation (cherry picked from commit 60b4200)
This was referenced Mar 30, 2022
mkrizek
removed
the
needs_triage
sivel
pushed a commit
that referenced
this pull request
Apr 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The
winrmconnection plugin callskinitin a new subprocess but explicitly defines a new environment dict to run with. This means that any changes in thePATHas seen by the Ansible process are lost causing it to potentially fail to findkinit. By preserving thePATHfor this subprocess it will be able to lookupkinitin the same environment as the caller.Fixes #77390
ISSUE TYPE
COMPONENT NAME
winrm